Chromium Code Reviews| Index: chrome/browser/android/bookmarks/bookmarks_bridge.cc |
| diff --git a/chrome/browser/android/bookmarks/bookmarks_bridge.cc b/chrome/browser/android/bookmarks/bookmarks_bridge.cc |
| index 7cd704af9ffb109dc649c64c43aa1fe404c48c6a..c74d034ce598603996f864788337ed61af9e3dbf 100644 |
| --- a/chrome/browser/android/bookmarks/bookmarks_bridge.cc |
| +++ b/chrome/browser/android/bookmarks/bookmarks_bridge.cc |
| @@ -144,6 +144,31 @@ void BookmarksBridge::GetPermanentNodeIDs(JNIEnv* env, |
| } |
| } |
| +void BookmarksBridge::GetEditablePermanentIDs(JNIEnv* env, |
| + jobject obj, |
| + jobject j_result_obj) { |
|
Kibeom Kim (inactive)
2014/08/28 05:11:03
nit: alien the jobject arguments to JNIEnv*
Ian Wen
2014/08/28 18:09:56
Done.
|
| + DCHECK(IsLoaded()); |
| + |
| + base::StackVector<const BookmarkNode*, 8> permanent_nodes; |
| + |
| + const BookmarkNode* root_node = bookmark_model_->root_node(); |
| + for (int i = 0; i < root_node->child_count(); ++i) { |
| + permanent_nodes->push_back(root_node->GetChild(i)); |
| + } |
| + permanent_nodes->push_back( |
| + partner_bookmarks_shim_->GetPartnerBookmarksRoot()); |
|
Kibeom Kim (inactive)
2014/08/28 05:11:03
I thought we cannot add/move nodes to partner book
Ian Wen
2014/08/28 18:09:56
Per comments of DiablePartnerBookmarkEditing(), Pa
|
| + |
| + for (base::StackVector<const BookmarkNode*, 8>::ContainerType::const_iterator |
| + it = permanent_nodes->begin(); |
| + it != permanent_nodes->end(); |
| + ++it) { |
| + if (*it != NULL && client_->CanBeEditedByUser((*it))) { |
|
Kibeom Kim (inactive)
2014/08/28 05:11:03
IIRC, partner bookmark nodes cannot be queried by
Ian Wen
2014/08/28 18:09:56
Done.
|
| + Java_BookmarksBridge_addToBookmarkIdList( |
| + env, j_result_obj, (*it)->id(), GetBookmarkType(*it)); |
| + } |
| + } |
| +} |
| + |
| void BookmarksBridge::GetChildIDs(JNIEnv* env, |
| jobject obj, |
| jlong id, |