[Enhanced Bookmark] Add GetAllFoldersWithDepth in bookmark bridge

chrome/browser/android/bookmarks/bookmarks_bridge.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/bookmarks/bookmarks_bridge.h"
 
 #include "base/android/jni_string.h"
 #include "base/containers/stack_container.h"
 #include "base/prefs/pref_service.h"
 #include "chrome/browser/bookmarks/bookmark_model_factory.h"
@@ skipping 126 matching lines @@
            it = permanent_nodes->begin();
        it != permanent_nodes->end();
        ++it) {
     if (*it != NULL) {
       Java_BookmarksBridge_addToBookmarkIdList(
           env, j_result_obj, (*it)->id(), GetBookmarkType(*it));
     }
   }
 }
 
+void BookmarksBridge::GetEditablePermanentIDs(JNIEnv* env,
+                             jobject obj,
+                             jobject j_result_obj) {

[Kibeom Kim (inactive), 2014/08/28 05:11:03]

nit: alien the jobject arguments to JNIEnv*

[Ian Wen, 2014/08/28 18:09:56]

Done.

+  DCHECK(IsLoaded());
+
+  base::StackVector<const BookmarkNode*, 8> permanent_nodes;
+
+  const BookmarkNode* root_node = bookmark_model_->root_node();
+  for (int i = 0; i < root_node->child_count(); ++i) {
+    permanent_nodes->push_back(root_node->GetChild(i));
+  }
+  permanent_nodes->push_back(
+      partner_bookmarks_shim_->GetPartnerBookmarksRoot());

[Kibeom Kim (inactive), 2014/08/28 05:11:03]

I thought we cannot add/move nodes to partner bookmarks, could you double check?
(I think looking up the partner bookmark class comments should be enough)

[Ian Wen, 2014/08/28 18:09:56]

Per comments of DiablePartnerBookmarkEditing(), Partner bookmark can be edited
if our partner permits user doing so. I added extra check for it.
On 2014/08/28 05:11:03, Kibeom Kim wrote:

+
+  for (base::StackVector<const BookmarkNode*, 8>::ContainerType::const_iterator
+           it = permanent_nodes->begin();
+       it != permanent_nodes->end();
+       ++it) {
+    if (*it != NULL && client_->CanBeEditedByUser((*it))) {

[Kibeom Kim (inactive), 2014/08/28 05:11:03]

IIRC, partner bookmark nodes cannot be queried by client_ . We have many partner
bookmark code examples in this file.

[Ian Wen, 2014/08/28 18:09:56]

Done.

+      Java_BookmarksBridge_addToBookmarkIdList(
+          env, j_result_obj, (*it)->id(), GetBookmarkType(*it));
+    }
+  }
+}
+
 void BookmarksBridge::GetChildIDs(JNIEnv* env,
                                   jobject obj,
                                   jlong id,
                                   jint type,
                                   jboolean get_folders,
                                   jboolean get_bookmarks,
                                   jobject j_result_obj) {
   DCHECK(IsLoaded());
 
   const BookmarkNode* parent = GetNodeByID(id, type);
@@ skipping 495 matching lines @@
   BookmarkModelChanged();
 }
 
 void BookmarksBridge::PartnerShimLoaded(PartnerBookmarksShim* shim) {
   NotifyIfDoneLoading();
 }
 
 void BookmarksBridge::ShimBeingDeleted(PartnerBookmarksShim* shim) {
   partner_bookmarks_shim_ = NULL;
 }