Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(771)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/BookmarksBridge.java

Issue 506353003: [Enhanced Bookmark] Add GetAllFoldersWithDepth in bookmark bridge (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/BookmarksBridge.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/BookmarksBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/BookmarksBridge.java
index 87b1061f9d94316a33c3bb9a53f7958f5136fa3e..24663afb16d8afac3deb37c7681d2615865d781a 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/BookmarksBridge.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/BookmarksBridge.java
@@ -169,7 +169,9 @@ public class BookmarksBridge {
}
/**
- * @return All the permanent nodes.
+ * @return All the permanent nodes, including root node and managed folder.
+ * Note every bookmark node below "bookmark bar", "other bookmark",
+ * and "mobile bookmark" is also child of root node.
*/
public List<BookmarkId> getPermanentNodeIDs() {
assert mIsNativeBookmarkModelLoaded;
@@ -179,6 +181,16 @@ public class BookmarksBridge {
}
/**
+ * @return All permanent folder nodes that are not root nor under managed folder.
+ */
+ public List<BookmarkId> getEditablePermanentIDs() {
+ assert mIsNativeBookmarkModelLoaded;
+ List<BookmarkId> result = new ArrayList<BookmarkId>();
+ nativeGetEditablePermanentIDs(mNativeBookmarksBridge, result);
+ return result;
+ }
+
+ /**
* Reads sub-folder IDs, sub-bookmark IDs, or both of the given folder.
*
* @param getFolders Whether sub-folders should be returned.
@@ -413,6 +425,8 @@ public class BookmarksBridge {
int type);
private native void nativeGetPermanentNodeIDs(long nativeBookmarksBridge,
List<BookmarkId> bookmarksList);
+ private native void nativeGetEditablePermanentIDs(long nativeBookmarksBridge,
+ List<BookmarkId> bookmarksList);
private native void nativeGetChildIDs(long nativeBookmarksBridge, long id, int type,
boolean getFolders, boolean getBookmarks, List<BookmarkId> bookmarksList);
private native void nativeGetAllBookmarkIDsOrderedByCreationDate(long nativeBookmarksBridge,

Powered by Google App Engine
This is Rietveld 408576698