Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: mojo/public/cpp/application/lib/application_runner_chromium.cc

Issue 506353002: Make HandleWatcher watch on the same thread if the thread is running a MessagePumpMojo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/cpp/application/lib/application_runner_chromium.cc
diff --git a/mojo/public/cpp/application/lib/application_runner_chromium.cc b/mojo/public/cpp/application/lib/application_runner_chromium.cc
index 6f5764b8f3a6e1be0dea2a874e6863efd7091fd1..3216cd32801e4ba8f9fe7c35ffef4f2a741641e7 100644
--- a/mojo/public/cpp/application/lib/application_runner_chromium.cc
+++ b/mojo/public/cpp/application/lib/application_runner_chromium.cc
@@ -6,7 +6,9 @@
#include "base/at_exit.h"
#include "base/command_line.h"
+#include "base/memory/scoped_ptr.h"
#include "base/message_loop/message_loop.h"
+#include "mojo/common/message_pump_mojo.h"
#include "mojo/public/cpp/application/application_delegate.h"
#include "mojo/public/cpp/application/application_impl.h"
@@ -21,27 +23,39 @@ void ApplicationImpl::Terminate() {
ApplicationRunnerChromium::ApplicationRunnerChromium(
ApplicationDelegate* delegate)
: delegate_(scoped_ptr<ApplicationDelegate>(delegate)),
- message_loop_type_(base::MessageLoop::TYPE_DEFAULT) {}
+ message_loop_type_(base::MessageLoop::TYPE_CUSTOM),
+ has_run_(false) {}
ApplicationRunnerChromium::~ApplicationRunnerChromium() {}
void ApplicationRunnerChromium::set_message_loop_type(
base::MessageLoop::Type type) {
- DCHECK_EQ(base::MessageLoop::TYPE_DEFAULT, message_loop_type_);
+ DCHECK_NE(base::MessageLoop::TYPE_CUSTOM, type);
+ DCHECK(!has_run_);
+
message_loop_type_ = type;
}
MojoResult ApplicationRunnerChromium::Run(MojoHandle shell_handle) {
+ DCHECK(!has_run_);
+ has_run_ = true;
+
base::CommandLine::Init(0, NULL);
#if !defined(COMPONENT_BUILD)
base::AtExitManager at_exit;
#endif
{
- base::MessageLoop loop(message_loop_type_);
+ scoped_ptr<base::MessageLoop> loop;
+ if (message_loop_type_ == base::MessageLoop::TYPE_CUSTOM) {
+ loop.reset(new base::MessageLoop(common::MessagePumpMojo::Create()));
+ } else {
+ loop.reset(new base::MessageLoop(message_loop_type_));
+ }
+
ApplicationImpl impl(delegate_.get(),
MakeScopedHandle(MessagePipeHandle(shell_handle)));
- loop.Run();
+ loop->Run();
}
delegate_.reset();
return MOJO_RESULT_OK;
« mojo/common/handle_watcher.cc ('K') | « mojo/public/cpp/application/application_runner_chromium.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698