Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Side by Side Diff: mojo/public/cpp/application/lib/application_runner_chromium.cc

Issue 506353002: Make HandleWatcher watch on the same thread if the thread is running a MessagePumpMojo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "mojo/public/cpp/application/application_runner_chromium.h" 5 #include "mojo/public/cpp/application/application_runner_chromium.h"
6 6
7 #include "base/at_exit.h" 7 #include "base/at_exit.h"
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 #include "base/memory/scoped_ptr.h"
9 #include "base/message_loop/message_loop.h" 10 #include "base/message_loop/message_loop.h"
11 #include "mojo/common/message_pump_mojo.h"
10 #include "mojo/public/cpp/application/application_delegate.h" 12 #include "mojo/public/cpp/application/application_delegate.h"
11 #include "mojo/public/cpp/application/application_impl.h" 13 #include "mojo/public/cpp/application/application_impl.h"
12 14
13 namespace mojo { 15 namespace mojo {
14 16
15 // static 17 // static
16 void ApplicationImpl::Terminate() { 18 void ApplicationImpl::Terminate() {
17 if (base::MessageLoop::current()->is_running()) 19 if (base::MessageLoop::current()->is_running())
18 base::MessageLoop::current()->Quit(); 20 base::MessageLoop::current()->Quit();
19 } 21 }
20 22
21 ApplicationRunnerChromium::ApplicationRunnerChromium( 23 ApplicationRunnerChromium::ApplicationRunnerChromium(
22 ApplicationDelegate* delegate) 24 ApplicationDelegate* delegate)
23 : delegate_(scoped_ptr<ApplicationDelegate>(delegate)), 25 : delegate_(scoped_ptr<ApplicationDelegate>(delegate)),
24 message_loop_type_(base::MessageLoop::TYPE_DEFAULT) {} 26 message_loop_type_(base::MessageLoop::TYPE_CUSTOM),
27 has_run_(false) {}
25 28
26 ApplicationRunnerChromium::~ApplicationRunnerChromium() {} 29 ApplicationRunnerChromium::~ApplicationRunnerChromium() {}
27 30
28 void ApplicationRunnerChromium::set_message_loop_type( 31 void ApplicationRunnerChromium::set_message_loop_type(
29 base::MessageLoop::Type type) { 32 base::MessageLoop::Type type) {
30 DCHECK_EQ(base::MessageLoop::TYPE_DEFAULT, message_loop_type_); 33 DCHECK_NE(base::MessageLoop::TYPE_CUSTOM, type);
34 DCHECK(!has_run_);
35
31 message_loop_type_ = type; 36 message_loop_type_ = type;
32 } 37 }
33 38
34 MojoResult ApplicationRunnerChromium::Run(MojoHandle shell_handle) { 39 MojoResult ApplicationRunnerChromium::Run(MojoHandle shell_handle) {
40 DCHECK(!has_run_);
41 has_run_ = true;
42
35 base::CommandLine::Init(0, NULL); 43 base::CommandLine::Init(0, NULL);
36 #if !defined(COMPONENT_BUILD) 44 #if !defined(COMPONENT_BUILD)
37 base::AtExitManager at_exit; 45 base::AtExitManager at_exit;
38 #endif 46 #endif
39 47
40 { 48 {
41 base::MessageLoop loop(message_loop_type_); 49 scoped_ptr<base::MessageLoop> loop;
50 if (message_loop_type_ == base::MessageLoop::TYPE_CUSTOM) {
51 loop.reset(new base::MessageLoop(common::MessagePumpMojo::Create()));
52 } else {
53 loop.reset(new base::MessageLoop(message_loop_type_));
54 }
55
42 ApplicationImpl impl(delegate_.get(), 56 ApplicationImpl impl(delegate_.get(),
43 MakeScopedHandle(MessagePipeHandle(shell_handle))); 57 MakeScopedHandle(MessagePipeHandle(shell_handle)));
44 loop.Run(); 58 loop->Run();
45 } 59 }
46 delegate_.reset(); 60 delegate_.reset();
47 return MOJO_RESULT_OK; 61 return MOJO_RESULT_OK;
48 } 62 }
49 63
50 } // namespace mojo 64 } // namespace mojo
OLDNEW
« mojo/common/handle_watcher.cc ('K') | « mojo/public/cpp/application/application_runner_chromium.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698