Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 506273002: Aggregate damage rects in surface aggregator (Closed)

Created:
6 years, 3 months ago by jbauman
Modified:
6 years, 3 months ago
Reviewers:
jamesr
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Aggregate damage rects in surface aggregator The surface aggregator should keep track of the last frame from each surface that was aggregated, and use that to determine what the appropriate damage rect is for the next aggregation. BUG= TEST=chrome --use-surfaces --disable-gpu Committed: https://crrev.com/2eb7fbb502958e0a5d34e1a0c43f998419117217 Cr-Commit-Position: refs/heads/master@{#292227}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+246 lines, -54 lines) Patch
M cc/surfaces/display.h View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/surfaces/display.cc View 1 2 3 chunks +6 lines, -7 lines 0 comments Download
M cc/surfaces/surface.h View 2 chunks +4 lines, -0 lines 0 comments Download
M cc/surfaces/surface.cc View 1 2 2 chunks +9 lines, -1 line 0 comments Download
M cc/surfaces/surface_aggregator.h View 1 2 3 chunks +14 lines, -6 lines 0 comments Download
M cc/surfaces/surface_aggregator.cc View 5 chunks +29 lines, -12 lines 0 comments Download
M cc/surfaces/surface_aggregator_unittest.cc View 1 9 chunks +181 lines, -20 lines 0 comments Download
M cc/surfaces/surfaces_pixeltest.cc View 3 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
jbauman
jbauman@chromium.org changed reviewers: + jamesr@chromium.org
6 years, 3 months ago (2014-08-26 21:29:39 UTC) #1
jbauman
Ok, have a new version that keeps track of the last frame that was drawn ...
6 years, 3 months ago (2014-08-26 21:29:39 UTC) #2
jamesr
lgtm https://codereview.chromium.org/506273002/diff/20001/cc/surfaces/surface.cc File cc/surfaces/surface.cc (right): https://codereview.chromium.org/506273002/diff/20001/cc/surfaces/surface.cc#newcode13 cc/surfaces/surface.cc:13: : surface_id_(id), size_(size), factory_(factory), frame_index_(2) { why 2? ...
6 years, 3 months ago (2014-08-26 22:06:22 UTC) #3
jbauman
The CQ bit was checked by jbauman@chromium.org
6 years, 3 months ago (2014-08-27 20:27:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbauman@chromium.org/506273002/40001
6 years, 3 months ago (2014-08-27 20:29:14 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 2bb7359598121486ddfb3e056404334ac783fe13
6 years, 3 months ago (2014-08-27 21:24:55 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:54:10 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2eb7fbb502958e0a5d34e1a0c43f998419117217
Cr-Commit-Position: refs/heads/master@{#292227}

Powered by Google App Engine
This is Rietveld 408576698