Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 506253003: Revert "Split bundle generation steps so that API registration is generated in browser, not common." (Closed)

Created:
6 years, 3 months ago by awong
Modified:
6 years, 3 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, extensions-reviews_chromium.org, vsevik, jam, yurys, paulirish+reviews_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, chromium-apps-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Committed: https://crrev.com/8f65982274893958898690b22e1c0c9ed4968857 Cr-Commit-Position: refs/heads/master@{#292059}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+426 lines, -678 lines) Patch
M build/json_schema_bundle_compile.gypi View 2 chunks +20 lines, -20 lines 0 comments Download
D build/json_schema_bundle_registration_compile.gypi View 1 chunk +0 lines, -78 lines 0 comments Download
M build/json_schema_compile.gypi View 3 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/devtools/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
D chrome/browser/extensions/api/api_registration.gyp View 1 chunk +0 lines, -41 lines 0 comments Download
M chrome/browser/extensions/chrome_extensions_browser_client.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/performance_monitor/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 3 chunks +0 lines, -3 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/api/BUILD.gn View 1 chunk +32 lines, -12 lines 0 comments Download
M chrome/common/extensions/api/api.gyp View 2 chunks +210 lines, -1 line 0 comments Download
D chrome/common/extensions/api/schemas.gni View 1 chunk +0 lines, -34 lines 0 comments Download
D chrome/common/extensions/api/schemas.gypi View 1 chunk +0 lines, -194 lines 0 comments Download
M content/app/content_main_runner.cc View 4 chunks +2 lines, -7 lines 0 comments Download
M extensions/BUILD.gn View 2 chunks +1 line, -2 lines 0 comments Download
M extensions/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D extensions/browser/api/api_registration.gyp View 1 chunk +0 lines, -28 lines 0 comments Download
M extensions/common/api/BUILD.gn View 1 chunk +21 lines, -9 lines 0 comments Download
M extensions/common/api/api.gyp View 1 chunk +48 lines, -1 line 0 comments Download
D extensions/common/api/schemas.gni View 1 chunk +0 lines, -17 lines 0 comments Download
D extensions/common/api/schemas.gypi View 1 chunk +0 lines, -51 lines 0 comments Download
M extensions/extensions.gyp View 2 chunks +0 lines, -2 lines 0 comments Download
M extensions/generated_extensions_api.gni View 6 chunks +44 lines, -88 lines 0 comments Download
M extensions/shell/app_shell.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
D extensions/shell/browser/api/api_registration.gyp View 1 chunk +0 lines, -21 lines 0 comments Download
M extensions/shell/browser/shell_extensions_browser_client.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/shell/common/api/api.gyp View 1 chunk +18 lines, -1 line 0 comments Download
D extensions/shell/common/api/schemas.gypi View 1 chunk +0 lines, -20 lines 0 comments Download
M tools/json_schema_compiler/compiler.py View 6 chunks +14 lines, -25 lines 0 comments Download
M tools/json_schema_compiler/cpp_bundle_generator.py View 1 chunk +2 lines, -3 lines 0 comments Download
M ui/accessibility/BUILD.gn View 1 chunk +2 lines, -1 line 0 comments Download
M ui/accessibility/accessibility.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
awong
ajwong@chromium.org changed reviewers: + yoz@chromium.org
6 years, 3 months ago (2014-08-27 01:10:03 UTC) #1
awong
Committed patchset #1 to pending queue manually as 6df8c62 (presubmit successful).
6 years, 3 months ago (2014-08-27 01:10:57 UTC) #2
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:48:24 UTC) #3
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/8f65982274893958898690b22e1c0c9ed4968857
Cr-Commit-Position: refs/heads/master@{#292059}

Powered by Google App Engine
This is Rietveld 408576698