build/json_schema_compile.gypi - Issue 506253003: Revert "Split bundle generation steps so that API registration is generated in browser, not common."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/json_schema_compile.gypi

Issue 506253003: Revert "Split bundle generation steps so that API registration is generated in browser, not common." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/json_schema_compile.gypi

diff --git a/build/json_schema_compile.gypi b/build/json_schema_compile.gypi

index 9672f797e819fad89803bac82bd70c8a4f7633b5..d164748508f20afdcae34cbcfe14b22a6fb5b5b5 100644

--- a/build/json_schema_compile.gypi

+++ b/build/json_schema_compile.gypi

@@ -15,8 +15,11 @@

# namespace, like "toplevel::%(namespace)s_api".

# Functions and namespaces can be excluded by setting "nocompile" to true.

+ # The default root path of API implementation sources is

+ # chrome/browser/extensions/api and can be overridden by setting "impl_dir".

'api_gen_dir': '<(DEPTH)/tools/json_schema_compiler',

'api_gen': '<(api_gen_dir)/compiler.py',

+ 'impl_dir%': 'chrome/browser/extensions/api',

'rules': [

{

@@ -54,6 +57,7 @@

'--destdir=<(SHARED_INTERMEDIATE_DIR)',

'--namespace=<(root_namespace)',

'--generator=cpp',

+ '--impl-dir=<(impl_dir)'

'message': 'Generating C++ code from <(RULE_INPUT_PATH) json files',

'process_outputs_as_sources': 1,

@@ -92,6 +96,7 @@

'--destdir=<(SHARED_INTERMEDIATE_DIR)',

'--namespace=<(root_namespace)',

'--generator=cpp',

+ '--impl-dir=<(impl_dir)'

'message': 'Generating C++ code from <(RULE_INPUT_PATH) IDL files',

'process_outputs_as_sources': 1,

« no previous file with comments | « build/json_schema_bundle_registration_compile.gypi ('k') | chrome/browser/BUILD.gn » ('j') | no next file with comments »