Issue 506143002: Refactor MachMultiprocess

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 506143002: Refactor MachMultiprocess (Closed)

Created:
6 years, 3 months ago by Mark Mentovai

Modified:
6 years, 3 months ago

Reviewers:
Robert Sesek

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master

Project:
crashpad

Visibility:
Public.

Refactor MachMultiprocess into a Multiprocess base class without any knowledge of Mach. MachMultiprocess builds on this new base class. TEST=util_test MachMultiprocess.*:Multiprocess.* R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/ff26ea6db913

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+327 lines, -318 lines)			Patch
M	util/mac/process_reader_test.cc	View	6 chunks	+6 lines, -8 lines	0 comments	Download
M	util/test/mac/mach_multiprocess.h	View	3 chunks	+42 lines, -61 lines	0 comments	Download
M	util/test/mac/mach_multiprocess.cc	View	8 chunks	+18 lines, -128 lines	0 comments	Download
M	util/test/mac/mach_multiprocess_test.cc	View	2 chunks	+5 lines, -45 lines	0 comments	Download
A +	util/test/multiprocess.h	View	3 chunks	+62 lines, -61 lines	0 comments	Download
A	util/test/multiprocess.cc	View	1 chunk	+180 lines, -0 lines	0 comments	Download
A +	util/test/multiprocess_test.cc	View	4 chunks	+11 lines, -15 lines	0 comments	Download
M	util/util.gyp	View	2 chunks	+3 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

Mark Mentovai

mark@chromium.org changed reviewers: + rsesek@chromium.org

6 years, 3 months ago (2014-08-26 18:20:34 UTC) #1

Mark Mentovai

This depends on ScopedForbidReturn, https://codereview.chromium.org/493203005/.

6 years, 3 months ago (2014-08-26 18:20:35 UTC) #2

Mark Mentovai

6 years, 3 months ago (2014-08-26 21:10:26 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as ff26ea6db913 (presubmit successful).