Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Unified Diff: util/mac/process_reader_test.cc

Issue 506143002: Refactor MachMultiprocess (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | util/test/mac/mach_multiprocess.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: util/mac/process_reader_test.cc
diff --git a/util/mac/process_reader_test.cc b/util/mac/process_reader_test.cc
index a54589295b6f56f0ff567eeae8684c2f0e7af974..67d90995d6cb17ce875ee698e715779d2ef9bc6f 100644
--- a/util/mac/process_reader_test.cc
+++ b/util/mac/process_reader_test.cc
@@ -67,8 +67,8 @@ class ProcessReaderChild final : public MachMultiprocess {
~ProcessReaderChild() {}
- protected:
- void Parent() override {
+ private:
+ void MachMultiprocessParent() override {
ProcessReader process_reader;
ASSERT_TRUE(process_reader.Initialize(ChildTask()));
@@ -100,7 +100,7 @@ class ProcessReaderChild final : public MachMultiprocess {
ASSERT_EQ(1, rv) << ErrnoMessage("write");
}
- void Child() override {
+ void MachMultiprocessChild() override {
int write_fd = WritePipeFD();
mach_vm_address_t address =
@@ -116,7 +116,6 @@ class ProcessReaderChild final : public MachMultiprocess {
ASSERT_EQ(1, rv) << ErrnoMessage("read");
}
- private:
DISALLOW_COPY_AND_ASSIGN(ProcessReaderChild);
};
@@ -434,8 +433,8 @@ class ProcessReaderThreadedChild final : public MachMultiprocess {
~ProcessReaderThreadedChild() {}
- protected:
- void Parent() override {
+ private:
+ void MachMultiprocessParent() override {
ProcessReader process_reader;
ASSERT_TRUE(process_reader.Initialize(ChildTask()));
@@ -486,7 +485,7 @@ class ProcessReaderThreadedChild final : public MachMultiprocess {
ASSERT_EQ(1, rv) << ErrnoMessage("write");
}
- void Child() override {
+ void MachMultiprocessChild() override {
TestThreadPool thread_pool;
thread_pool.StartThreads(thread_count_);
if (testing::Test::HasFatalFailure()) {
@@ -550,7 +549,6 @@ class ProcessReaderThreadedChild final : public MachMultiprocess {
ASSERT_EQ(1, rv) << ErrnoMessage("read");
}
- private:
size_t thread_count_;
DISALLOW_COPY_AND_ASSIGN(ProcessReaderThreadedChild);
« no previous file with comments | « no previous file | util/test/mac/mach_multiprocess.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698