Fixes moving fully occluded windows when the a11y keyboard shows.

Fixes moving fully occluded windows when the a11y keyboard shows.


TEST=WorkspaceLayoutManagerKeyboardTest.AdjustWindowForA11yKeyboard
BUG=407094
Committed: https://crrev.com/54b4f85af7b2ced969435cc04d2b743cfd5f29e2
Cr-Commit-Position: refs/heads/master@{#292056}

[rsadam, 2014-08-26 18:07:53]

rsadam@chromium.org changed reviewers:
+ flackr@chromium.org

[rsadam, 2014-08-26 18:07:53]

Hi Rob,

This is a follow up CL that handles the special case of fully occluded windows.
PTAL!

[flackr, 2014-08-26 18:13:52]

https://codereview.chromium.org/506133002/diff/1/ash/wm/workspace/workspace_l...
File ash/wm/workspace/workspace_layout_manager.cc (right):

https://codereview.chromium.org/506133002/diff/1/ash/wm/workspace/workspace_l...
ash/wm/workspace/workspace_layout_manager.cc:153: gfx::Rect window_bounds =
window->GetBoundsInScreen();
GetBoundsInScreen will be incorrect if this happens during an animation. You
will get the current bounds rather than the target (i.e. end of all animations)
bounds.

https://codereview.chromium.org/506133002/diff/1/ash/wm/workspace/workspace_l...
ash/wm/workspace/workspace_layout_manager.cc:156: std::max(0, window_bounds.y()
- new_bounds.y());
This is somewhat confusing. Couldn't we just say window_bounds.bottom() -
new_bounds.y() rather than add the top offset and the intersection?

[rsadam, 2014-08-26 18:46:28]

Fixed based on our offline discussion.

https://codereview.chromium.org/506133002/diff/1/ash/wm/workspace/workspace_l...
File ash/wm/workspace/workspace_layout_manager.cc (right):

https://codereview.chromium.org/506133002/diff/1/ash/wm/workspace/workspace_l...
ash/wm/workspace/workspace_layout_manager.cc:153: gfx::Rect window_bounds =
window->GetBoundsInScreen();
On 2014/08/26 18:13:51, flackr wrote:
> GetBoundsInScreen will be incorrect if this happens during an animation. You
> will get the current bounds rather than the target (i.e. end of all
animations)
> bounds.

Done.

https://codereview.chromium.org/506133002/diff/1/ash/wm/workspace/workspace_l...
ash/wm/workspace/workspace_layout_manager.cc:156: std::max(0, window_bounds.y()
- new_bounds.y());
On 2014/08/26 18:13:52, flackr wrote:
> This is somewhat confusing. Couldn't we just say window_bounds.bottom() -
> new_bounds.y() rather than add the top offset and the intersection?

Done.

[flackr, 2014-08-26 21:02:05]

lgtm

[rsadam, 2014-08-26 22:59:17]

The CQ bit was checked by rsadam@chromium.org

[commit-bot: I haz the power, 2014-08-26 23:02:18]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rsadam@chromium.org/506133002/20001

[commit-bot: I haz the power, 2014-08-27 00:17:57]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[commit-bot: I haz the power, 2014-08-27 00:37:59]

Committed patchset #2 (20001) as c90f1a465dbd0bc56bd83956baa9885562514ef3

[commit-bot: I haz the power, 2014-09-10 02:48:17]

Patchset 2 (id:??) landed as
https://crrev.com/54b4f85af7b2ced969435cc04d2b743cfd5f29e2
Cr-Commit-Position: refs/heads/master@{#292056}