Fixes moving fully occluded windows when the a11y keyboard shows.

ash/wm/workspace/workspace_layout_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/wm/workspace/workspace_layout_manager.h"
 
 #include <algorithm>
 
 #include "ash/display/display_controller.h"
 #include "ash/root_window_controller.h"
@@ skipping 132 matching lines @@
       text_input_client->GetAttachedWindow()->GetToplevelWindow();
   if (!window || !window_->Contains(window))
     return;
   wm::WindowState* window_state = wm::GetWindowState(window);
   if (!new_bounds.IsEmpty()) {
     // Store existing bounds to be restored before resizing for keyboard if it
     // is not already stored.
     if (!window_state->HasRestoreBounds())
       window_state->SaveCurrentBoundsForRestore();
 
-    gfx::Rect window_bounds = ScreenUtil::ConvertRectToScreen(
-        window_,
-        window->GetTargetBounds());
+    gfx::Rect window_bounds = window->GetBoundsInScreen();

[flackr, 2014/08/26 18:13:51]

GetBoundsInScreen will be incorrect if this happens during an animation. You
will get the current bounds rather than the target (i.e. end of all animations)
bounds.

[rsadam, 2014/08/26 18:46:28]

Done.

     gfx::Rect intersect = gfx::IntersectRects(window_bounds, new_bounds);
-    int shift = std::min(intersect.height(),
+    int vertical_displacement = intersect.height() +
+        std::max(0, window_bounds.y() - new_bounds.y());

[flackr, 2014/08/26 18:13:52]

This is somewhat confusing. Couldn't we just say window_bounds.bottom() -
new_bounds.y() rather than add the top offset and the intersection?

[rsadam, 2014/08/26 18:46:28]

Done.

+
+    // Prevent window from being pushed out of the work space.
+    int shift = std::min(vertical_displacement,
                          window->bounds().y() - work_area_in_parent_.y());
     if (shift > 0) {
       gfx::Point origin(window->bounds().x(), window->bounds().y() - shift);
       SetChildBounds(window, gfx::Rect(origin, window->bounds().size()));
     }
   } else if (window_state->HasRestoreBounds()) {
     // Keyboard hidden, restore original bounds if they exist.
     window_state->SetAndClearRestoreBounds();
   }
 }
@@ skipping 150 matching lines @@
   bool is_fullscreen = GetRootWindowController(
       window_->GetRootWindow())->GetWindowForFullscreenMode() != NULL;
   if (is_fullscreen != is_fullscreen_) {
     ash::Shell::GetInstance()->NotifyFullscreenStateChange(
         is_fullscreen, window_->GetRootWindow());
     is_fullscreen_ = is_fullscreen;
   }
 }
 
 }  // namespace ash