mojo/services/public/cpp/view_manager/tests/view_manager_unittest.cc - Issue 506103002: Rename ApplicationLoader::OnServiceError to OnApplicationError

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/services/public/cpp/view_manager/tests/view_manager_unittest.cc

Issue 506103002: Rename ApplicationLoader::OnServiceError to OnApplicationError (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge nits Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/application_manager/background_shell_application_loader_unittest.cc ('k') | mojo/services/view_manager/view_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/services/public/cpp/view_manager/tests/view_manager_unittest.cc

diff --git a/mojo/services/public/cpp/view_manager/tests/view_manager_unittest.cc b/mojo/services/public/cpp/view_manager/tests/view_manager_unittest.cc

index 9f4729292b5afec4747109194fce360fcbfd22af..c9419a4ac539aebfe448519935c66edfe9dc13c8 100644

--- a/mojo/services/public/cpp/view_manager/tests/view_manager_unittest.cc

+++ b/mojo/services/public/cpp/view_manager/tests/view_manager_unittest.cc

@@ -64,8 +64,8 @@ class ConnectApplicationLoader : public ApplicationLoader,

apps_.push_back(app.release());

}

- virtual void OnServiceError(ApplicationManager* manager,

- const GURL& url) OVERRIDE {}

+ virtual void OnApplicationError(ApplicationManager* manager,

+ const GURL& url) OVERRIDE {}

virtual bool ConfigureIncomingConnection(ApplicationConnection* connection)

OVERRIDE {