Chromecast: command-line switch to override the UMA metric upload URL.

chromecast/metrics/cast_metrics_service_client.cc

Index: chromecast/metrics/cast_metrics_service_client.cc
diff --git a/chromecast/metrics/cast_metrics_service_client.cc b/chromecast/metrics/cast_metrics_service_client.cc
index 80e80eaab1182ec47ac7bb8c63f643239507728d..7ad0204ae8e16ad817c3cee35c6116f6bd32e94d 100644
--- a/chromecast/metrics/cast_metrics_service_client.cc
+++ b/chromecast/metrics/cast_metrics_service_client.cc
@@ -4,8 +4,10 @@
 
 #include "chromecast/metrics/cast_metrics_service_client.h"
 
+#include "base/command_line.h"
 #include "base/i18n/rtl.h"
 #include "chromecast/common/chromecast_config.h"
+#include "chromecast/common/chromecast_switches.h"
 #include "chromecast/metrics/platform_metrics_providers.h"
 #include "components/metrics/metrics_provider.h"
 #include "components/metrics/metrics_service.h"
@@ -69,10 +71,18 @@ CastMetricsServiceClient::CreateUploader(
     const std::string& server_url,
     const std::string& mime_type,
     const base::Callback<void(int)>& on_upload_complete) {
+  std::string uma_server_url(server_url);
+  if (base::CommandLine::ForCurrentProcess()->

[Alexei Svitkine (slow), 2014/08/29 23:51:41]

Nit: Make a local var for this to avoid calling it twice.

+      HasSwitch(switches::kOverrideMetricsUploadUrl)) {
+    uma_server_url.assign(
+        base::CommandLine::ForCurrentProcess()->
+            GetSwitchValueASCII(switches::kOverrideMetricsUploadUrl));
+  }
+  DCHECK(!uma_server_url.empty());
   return scoped_ptr< ::metrics::MetricsLogUploader>(
       new ::metrics::NetMetricsLogUploader(
           request_context_,
-          server_url,
+          uma_server_url,
           mime_type,
           on_upload_complete));
 }