Chromecast: command-line switch to override the UMA metric upload URL.

chromecast/metrics/cast_metrics_service_client.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromecast/metrics/cast_metrics_service_client.h"
 
+#include "base/command_line.h"
 #include "base/i18n/rtl.h"
 #include "chromecast/common/chromecast_config.h"
+#include "chromecast/common/chromecast_switches.h"
 #include "chromecast/metrics/platform_metrics_providers.h"
 #include "components/metrics/metrics_provider.h"
 #include "components/metrics/metrics_service.h"
 #include "components/metrics/metrics_state_manager.h"
 #include "components/metrics/net/net_metrics_log_uploader.h"
 
 namespace chromecast {
 namespace metrics {
 
 // static
@@ skipping 43 matching lines @@
 void CastMetricsServiceClient::CollectFinalMetrics(
     const base::Closure& done_callback) {
   done_callback.Run();
 }
 
 scoped_ptr< ::metrics::MetricsLogUploader>
 CastMetricsServiceClient::CreateUploader(
     const std::string& server_url,
     const std::string& mime_type,
     const base::Callback<void(int)>& on_upload_complete) {
+  std::string uma_server_url(server_url);
+  if (base::CommandLine::ForCurrentProcess()->

[Alexei Svitkine (slow), 2014/08/29 23:51:41]

Nit: Make a local var for this to avoid calling it twice.

+      HasSwitch(switches::kOverrideMetricsUploadUrl)) {
+    uma_server_url.assign(
+        base::CommandLine::ForCurrentProcess()->
+            GetSwitchValueASCII(switches::kOverrideMetricsUploadUrl));
+  }
+  DCHECK(!uma_server_url.empty());
   return scoped_ptr< ::metrics::MetricsLogUploader>(
       new ::metrics::NetMetricsLogUploader(
           request_context_,
-          server_url,
+          uma_server_url,
           mime_type,
           on_upload_complete));
 }
 
 void CastMetricsServiceClient::EnableMetricsService(bool enabled) {
   if (enabled) {
     metrics_service_->Start();
   } else {
     metrics_service_->Stop();
   }
@@ skipping 34 matching lines @@
 
 CastMetricsServiceClient::~CastMetricsServiceClient() {
 }
 
 bool CastMetricsServiceClient::IsReportingEnabled() {
   return PlatformIsReportingEnabled();
 }
 
 }  // namespace metrics
 }  // namespace chromecast