chrome/browser/ui/webui/extensions/extension_settings_handler.cc - Issue 505913002: Remove implicit conversions from scoped_refptr to T* in chrome/browser/ui/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/extensions/extension_settings_handler.cc

Issue 505913002: Remove implicit conversions from scoped_refptr to T* in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/location_bar/location_bar.cc ('K') | « chrome/browser/ui/webui/extensions/extension_icon_source.cc ('k') | chrome/browser/ui/webui/interstitials/interstitial_ui.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/extensions/extension_settings_handler.cc

diff --git a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc

index 7678bd6bd9f13e1916ad58b013ea8b23572b8a9e..b2fab16a4c1b20c906242e43f0470a3ea57cc52a 100644

--- a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc

+++ b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc

@@ -829,7 +829,7 @@ void ExtensionSettingsHandler::HandleRequestExtensionsData(

const ExtensionSet& enabled_set = registry->enabled_extensions();

for (ExtensionSet::const_iterator extension = enabled_set.begin();

extension != enabled_set.end(); ++extension) {

- if (ui_util::ShouldDisplayInExtensionSettings(*extension, profile)) {

+ if (ui_util::ShouldDisplayInExtensionSettings(extension->get(), profile)) {

extensions_list->Append(CreateExtensionDetailValue(

extension->get(),

GetInspectablePagesForExtension(extension->get(), true),

@@ -839,7 +839,7 @@ void ExtensionSettingsHandler::HandleRequestExtensionsData(

const ExtensionSet& disabled_set = registry->disabled_extensions();

for (ExtensionSet::const_iterator extension = disabled_set.begin();

extension != disabled_set.end(); ++extension) {

- if (ui_util::ShouldDisplayInExtensionSettings(*extension, profile)) {

+ if (ui_util::ShouldDisplayInExtensionSettings(extension->get(), profile)) {

extensions_list->Append(CreateExtensionDetailValue(

extension->get(),

GetInspectablePagesForExtension(extension->get(), false),

@@ -850,7 +850,7 @@ void ExtensionSettingsHandler::HandleRequestExtensionsData(

std::vector<ExtensionPage> empty_pages;

for (ExtensionSet::const_iterator extension = terminated_set.begin();

extension != terminated_set.end(); ++extension) {

- if (ui_util::ShouldDisplayInExtensionSettings(*extension, profile)) {

+ if (ui_util::ShouldDisplayInExtensionSettings(extension->get(), profile)) {

extensions_list->Append(CreateExtensionDetailValue(

extension->get(),

empty_pages, // Terminated process has no active pages.