chrome/browser/ui/views/tabs/tab.cc - Issue 505913002: Remove implicit conversions from scoped_refptr to T* in chrome/browser/ui/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/tabs/tab.cc

Issue 505913002: Remove implicit conversions from scoped_refptr to T* in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/location_bar/location_bar.cc ('K') | « chrome/browser/ui/views/ssl_client_certificate_selector_browsertest.cc ('k') | chrome/browser/ui/views/toolbar/browser_actions_container.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/tabs/tab.cc

diff --git a/chrome/browser/ui/views/tabs/tab.cc b/chrome/browser/ui/views/tabs/tab.cc

index 9ee20bd1cc96d67f3b82c1044c586fb0b89ba92e..af8b0993163b6214d1b8b53eeb08eca3a1d5ef28 100644

--- a/chrome/browser/ui/views/tabs/tab.cc

+++ b/chrome/browser/ui/views/tabs/tab.cc

@@ -542,7 +542,7 @@ void Tab::UpdateLoadingAnimation(TabRendererData::NetworkState state) {

void Tab::StartPulse() {

pulse_animation_.reset(new gfx::ThrobAnimation(this));

pulse_animation_->SetSlideDuration(kPulseDurationMs);

- if (animation_container_)

+ if (animation_container_.get())

pulse_animation_->SetContainer(animation_container_.get());

pulse_animation_->StartThrobbing(std::numeric_limits<int>::max());

}

@@ -572,7 +572,7 @@ void Tab::StartMiniTabTitleAnimation() {

base::TimeDelta timeout =

base::TimeDelta::FromMilliseconds(kMiniTitleChangeAnimationIntervalMS);

mini_title_change_animation_.reset(new gfx::MultiAnimation(parts, timeout));

- if (animation_container_)

+ if (animation_container_.get())

mini_title_change_animation_->SetContainer(animation_container_.get());

mini_title_change_animation_->set_delegate(this);

}