chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel_unittest.cc - Issue 505913002: Remove implicit conversions from scoped_refptr to T* in chrome/browser/ui/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel_unittest.cc

Issue 505913002: Remove implicit conversions from scoped_refptr to T* in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/location_bar/location_bar.cc ('K') | « chrome/browser/ui/tabs/tab_utils.cc ('k') | chrome/browser/ui/views/extensions/extension_install_dialog_view_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel_unittest.cc

diff --git a/chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel_unittest.cc b/chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel_unittest.cc

index 586c2484981d9a626c820ef68e1166c35c786149..f4ed8cbe369807cfeb8f359f455918aa4a131ee6 100644

--- a/chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel_unittest.cc

+++ b/chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel_unittest.cc

@@ -63,7 +63,7 @@ TEST_F(AppInfoPermissionsPanelTest, NoPermissionsObtainedCorrectly) {

.SetManifest(ValidAppManifest())

.SetID(kTestExtensionId)

.Build();

- AppInfoPermissionsPanel panel(&profile_, app);

+ AppInfoPermissionsPanel panel(&profile_, app.get());

EXPECT_TRUE(panel.GetActivePermissionMessages().empty());

EXPECT_TRUE(panel.GetRetainedFilePaths().empty());

@@ -87,7 +87,7 @@ TEST_F(AppInfoPermissionsPanelTest, RequiredPermissionsObtainedCorrectly) {

// a message

.SetID(kTestExtensionId)

.Build();

- AppInfoPermissionsPanel panel(&profile_, app);

+ AppInfoPermissionsPanel panel(&profile_, app.get());

const std::vector<base::string16> permission_messages =

panel.GetActivePermissionMessages();

@@ -117,7 +117,7 @@ TEST_F(AppInfoPermissionsPanelTest, OptionalPermissionsObtainedCorrectly) {

// a message

.SetID(kTestExtensionId)

.Build();

- AppInfoPermissionsPanel panel(&profile_, app);

+ AppInfoPermissionsPanel panel(&profile_, app.get());

// Optional permissions don't appear until they are 'activated' at runtime.

// TODO(sashab): Activate the optional permissions and ensure they are

@@ -140,7 +140,7 @@ TEST_F(AppInfoPermissionsPanelTest, RetainedFilePermissionsObtainedCorrectly) {

extensions::ListBuilder().Append("retainEntries")))))

.SetID(kTestExtensionId)

.Build();

- AppInfoPermissionsPanel panel(&profile_, app);

+ AppInfoPermissionsPanel panel(&profile_, app.get());

apps::SavedFilesService* files_service =

apps::SavedFilesService::Get(&profile_);

files_service->RegisterFileEntry(