chrome/browser/ui/omnibox/omnibox_navigation_observer.cc - Issue 505913002: Remove implicit conversions from scoped_refptr to T* in chrome/browser/ui/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/omnibox/omnibox_navigation_observer.cc

Issue 505913002: Remove implicit conversions from scoped_refptr to T* in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/location_bar/location_bar.cc ('K') | « chrome/browser/ui/omnibox/alternate_nav_infobar_delegate.cc ('k') | chrome/browser/ui/tabs/tab_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/omnibox/omnibox_navigation_observer.cc

diff --git a/chrome/browser/ui/omnibox/omnibox_navigation_observer.cc b/chrome/browser/ui/omnibox/omnibox_navigation_observer.cc

index 51a19b79cafeb0e157e92f9d981397cb276b1c76..040dbdefa2cfcd57bace95ae91c9f25a2bc92c59 100644

--- a/chrome/browser/ui/omnibox/omnibox_navigation_observer.cc

+++ b/chrome/browser/ui/omnibox/omnibox_navigation_observer.cc

@@ -77,7 +77,7 @@ OmniboxNavigationObserver::~OmniboxNavigationObserver() {

}

void OmniboxNavigationObserver::OnSuccessfulNavigation() {

- if (shortcuts_backend_)

+ if (shortcuts_backend_.get())

shortcuts_backend_->AddOrUpdateShortcut(text_, match_);

}