Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Unified Diff: mojo/system/message_pipe_unittest.cc

Issue 505863002: Mojo: Add static factory functions to MessagePipe. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/system/message_pipe_dispatcher_unittest.cc ('k') | mojo/system/multiprocess_message_pipe_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/system/message_pipe_unittest.cc
diff --git a/mojo/system/message_pipe_unittest.cc b/mojo/system/message_pipe_unittest.cc
index d0aae93d367577ce6affc82bd45df19a4193e09e..7cd9cbd9d26e2c0e5c4368be114293e197899924 100644
--- a/mojo/system/message_pipe_unittest.cc
+++ b/mojo/system/message_pipe_unittest.cc
@@ -28,7 +28,7 @@ namespace {
// - writing a message to a port, closing the other (would be the source) port,
// and reading it
TEST(MessagePipeTest, Basic) {
- scoped_refptr<MessagePipe> mp(new MessagePipe());
+ scoped_refptr<MessagePipe> mp(MessagePipe::CreateLocalLocal());
int32_t buffer[2];
const uint32_t kBufferSize = static_cast<uint32_t>(sizeof(buffer));
@@ -234,7 +234,7 @@ TEST(MessagePipeTest, Basic) {
}
TEST(MessagePipeTest, CloseWithQueuedIncomingMessages) {
- scoped_refptr<MessagePipe> mp(new MessagePipe());
+ scoped_refptr<MessagePipe> mp(MessagePipe::CreateLocalLocal());
int32_t buffer[1];
const uint32_t kBufferSize = static_cast<uint32_t>(sizeof(buffer));
@@ -268,7 +268,7 @@ TEST(MessagePipeTest, CloseWithQueuedIncomingMessages) {
}
TEST(MessagePipeTest, DiscardMode) {
- scoped_refptr<MessagePipe> mp(new MessagePipe());
+ scoped_refptr<MessagePipe> mp(MessagePipe::CreateLocalLocal());
int32_t buffer[2];
const uint32_t kBufferSize = static_cast<uint32_t>(sizeof(buffer));
@@ -406,7 +406,7 @@ TEST(MessagePipeTest, DiscardMode) {
}
TEST(MessagePipeTest, BasicWaiting) {
- scoped_refptr<MessagePipe> mp(new MessagePipe());
+ scoped_refptr<MessagePipe> mp(MessagePipe::CreateLocalLocal());
Waiter waiter;
HandleSignalsState hss;
@@ -538,7 +538,7 @@ TEST(MessagePipeTest, ThreadedWaiting) {
// Write to wake up waiter waiting for read.
{
- scoped_refptr<MessagePipe> mp(new MessagePipe());
+ scoped_refptr<MessagePipe> mp(MessagePipe::CreateLocalLocal());
test::SimpleWaiterThread thread(&result, &context);
thread.waiter()->Init();
@@ -572,7 +572,7 @@ TEST(MessagePipeTest, ThreadedWaiting) {
// Close to cancel waiter.
{
- scoped_refptr<MessagePipe> mp(new MessagePipe());
+ scoped_refptr<MessagePipe> mp(MessagePipe::CreateLocalLocal());
test::SimpleWaiterThread thread(&result, &context);
thread.waiter()->Init();
@@ -595,7 +595,7 @@ TEST(MessagePipeTest, ThreadedWaiting) {
// Close to make waiter un-wake-up-able.
{
- scoped_refptr<MessagePipe> mp(new MessagePipe());
+ scoped_refptr<MessagePipe> mp(MessagePipe::CreateLocalLocal());
test::SimpleWaiterThread thread(&result, &context);
thread.waiter()->Init();
« no previous file with comments | « mojo/system/message_pipe_dispatcher_unittest.cc ('k') | mojo/system/multiprocess_message_pipe_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698