Mojo: Add static factory functions to MessagePipe.

mojo/system/message_pipe_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "mojo/system/message_pipe.h"
 
 #include "base/memory/ref_counted.h"
 #include "base/threading/platform_thread.h"  // For |Sleep()|.
 #include "base/time/time.h"
 #include "mojo/system/waiter.h"
@@ skipping 10 matching lines @@
 //    - when there are no/one/two messages available for that port
 //    - with buffer size 0 (and null buffer) -- should get size
 //    - with too-small buffer -- should get size
 //    - also verify that buffers aren't modified when/where they shouldn't be
 //  - writing messages to a port
 //    - in the obvious scenarios (as above)
 //    - to a port that's been closed
 //  - writing a message to a port, closing the other (would be the source) port,
 //    and reading it
 TEST(MessagePipeTest, Basic) {
-  scoped_refptr<MessagePipe> mp(new MessagePipe());
+  scoped_refptr<MessagePipe> mp(MessagePipe::CreateLocalLocal());
 
   int32_t buffer[2];
   const uint32_t kBufferSize = static_cast<uint32_t>(sizeof(buffer));
   uint32_t buffer_size;
 
   // Nothing to read yet on port 0.
   buffer[0] = 123;
   buffer[1] = 456;
   buffer_size = kBufferSize;
   EXPECT_EQ(MOJO_RESULT_SHOULD_WAIT,
@@ skipping 185 matching lines @@
                             UserPointer<void>(buffer),
                             MakeUserPointer(&buffer_size),
                             0,
                             NULL,
                             MOJO_READ_MESSAGE_FLAG_NONE));
 
   mp->Close(1);
 }
 
 TEST(MessagePipeTest, CloseWithQueuedIncomingMessages) {
-  scoped_refptr<MessagePipe> mp(new MessagePipe());
+  scoped_refptr<MessagePipe> mp(MessagePipe::CreateLocalLocal());
 
   int32_t buffer[1];
   const uint32_t kBufferSize = static_cast<uint32_t>(sizeof(buffer));
   uint32_t buffer_size;
 
   // Write some messages from port 1 (to port 0).
   for (int32_t i = 0; i < 5; i++) {
     buffer[0] = i;
     EXPECT_EQ(MOJO_RESULT_OK,
               mp->WriteMessage(1,
@@ skipping 13 matching lines @@
                             NULL,
                             MOJO_READ_MESSAGE_FLAG_NONE));
   EXPECT_EQ(kBufferSize, buffer_size);
 
   // Close port 0 first, which should have outstanding (incoming) messages.
   mp->Close(0);
   mp->Close(1);
 }
 
 TEST(MessagePipeTest, DiscardMode) {
-  scoped_refptr<MessagePipe> mp(new MessagePipe());
+  scoped_refptr<MessagePipe> mp(MessagePipe::CreateLocalLocal());
 
   int32_t buffer[2];
   const uint32_t kBufferSize = static_cast<uint32_t>(sizeof(buffer));
   uint32_t buffer_size;
 
   // Write from port 1 (to port 0).
   buffer[0] = 789012345;
   buffer[1] = 0;
   EXPECT_EQ(MOJO_RESULT_OK,
             mp->WriteMessage(1,
@@ skipping 117 matching lines @@
                             MakeUserPointer(&buffer_size),
                             0,
                             NULL,
                             MOJO_READ_MESSAGE_FLAG_MAY_DISCARD));
 
   mp->Close(0);
   mp->Close(1);
 }
 
 TEST(MessagePipeTest, BasicWaiting) {
-  scoped_refptr<MessagePipe> mp(new MessagePipe());
+  scoped_refptr<MessagePipe> mp(MessagePipe::CreateLocalLocal());
   Waiter waiter;
   HandleSignalsState hss;
 
   int32_t buffer[1];
   const uint32_t kBufferSize = static_cast<uint32_t>(sizeof(buffer));
   uint32_t buffer_size;
 
   // Always writable (until the other port is closed).
   waiter.Init();
   hss = HandleSignalsState();
@@ skipping 111 matching lines @@
 
 TEST(MessagePipeTest, ThreadedWaiting) {
   int32_t buffer[1];
   const uint32_t kBufferSize = static_cast<uint32_t>(sizeof(buffer));
 
   MojoResult result;
   uint32_t context;
 
   // Write to wake up waiter waiting for read.
   {
-    scoped_refptr<MessagePipe> mp(new MessagePipe());
+    scoped_refptr<MessagePipe> mp(MessagePipe::CreateLocalLocal());
     test::SimpleWaiterThread thread(&result, &context);
 
     thread.waiter()->Init();
     ASSERT_EQ(MOJO_RESULT_OK,
               mp->AddWaiter(
                   1, thread.waiter(), MOJO_HANDLE_SIGNAL_READABLE, 1, NULL));
     thread.Start();
 
     buffer[0] = 123456789;
     // Write from port 0 (to port 1), which should wake up the waiter.
@@ skipping 13 matching lines @@
 
     mp->Close(0);
     mp->Close(1);
   }  // Joins |thread|.
   // The waiter should have woken up successfully.
   EXPECT_EQ(MOJO_RESULT_OK, result);
   EXPECT_EQ(1u, context);
 
   // Close to cancel waiter.
   {
-    scoped_refptr<MessagePipe> mp(new MessagePipe());
+    scoped_refptr<MessagePipe> mp(MessagePipe::CreateLocalLocal());
     test::SimpleWaiterThread thread(&result, &context);
 
     thread.waiter()->Init();
     ASSERT_EQ(MOJO_RESULT_OK,
               mp->AddWaiter(
                   1, thread.waiter(), MOJO_HANDLE_SIGNAL_READABLE, 2, NULL));
     thread.Start();
 
     // Close port 1 first -- this should result in the waiter being cancelled.
     mp->CancelAllWaiters(1);
     mp->Close(1);
 
     // Port 1 is closed, so |Dispatcher::RemoveWaiter()| wouldn't call into the
     // |MessagePipe| to remove any waiter.
 
     mp->Close(0);
   }  // Joins |thread|.
   EXPECT_EQ(MOJO_RESULT_CANCELLED, result);
   EXPECT_EQ(2u, context);
 
   // Close to make waiter un-wake-up-able.
   {
-    scoped_refptr<MessagePipe> mp(new MessagePipe());
+    scoped_refptr<MessagePipe> mp(MessagePipe::CreateLocalLocal());
     test::SimpleWaiterThread thread(&result, &context);
 
     thread.waiter()->Init();
     ASSERT_EQ(MOJO_RESULT_OK,
               mp->AddWaiter(
                   1, thread.waiter(), MOJO_HANDLE_SIGNAL_READABLE, 3, NULL));
     thread.Start();
 
     // Close port 0 first -- this should wake the waiter up, since port 1 will
     // never be readable.
     mp->CancelAllWaiters(0);
     mp->Close(0);
 
     HandleSignalsState hss;
     mp->RemoveWaiter(1, thread.waiter(), &hss);
     EXPECT_EQ(0u, hss.satisfied_signals);
     EXPECT_EQ(0u, hss.satisfiable_signals);
 
     mp->CancelAllWaiters(1);
     mp->Close(1);
   }  // Joins |thread|.
   EXPECT_EQ(MOJO_RESULT_FAILED_PRECONDITION, result);
   EXPECT_EQ(3u, context);
 }
 
 }  // namespace
 }  // namespace system
 }  // namespace mojo