Mojo: Add static factory functions to MessagePipe.

Committed: https://crrev.com/f830881ad8712d8f2baacf69ff97f1069ca9d976
Cr-Commit-Position: refs/heads/master@{#291919}

[darin (slow to review), 2014-08-25 21:56:58]

https://codereview.chromium.org/505863002/diff/1/mojo/system/remote_message_p...
File mojo/system/remote_message_pipe_unittest.cc (right):

https://codereview.chromium.org/505863002/diff/1/mojo/system/remote_message_p...
mojo/system/remote_message_pipe_unittest.cc:508: scoped_refptr<MessagePipe>
mp0(new MessagePipe(MessagePipe::LocalProxy()));
Had you considered a static constructor like MessagePipe::CreateLocalProxy()?
That would avoid the repeating of MessagePipe in the above line.

It looks like all constructor calls are heap allocations of the form "new
MessagePipe(MessagePipe::Blah)"

[viettrungluu, 2014-08-25 22:01:50]

On 2014/08/25 21:56:58, darin wrote:
>
https://codereview.chromium.org/505863002/diff/1/mojo/system/remote_message_p...
> File mojo/system/remote_message_pipe_unittest.cc (right):
> 
>
https://codereview.chromium.org/505863002/diff/1/mojo/system/remote_message_p...
> mojo/system/remote_message_pipe_unittest.cc:508: scoped_refptr<MessagePipe>
> mp0(new MessagePipe(MessagePipe::LocalProxy()));
> Had you considered a static constructor like MessagePipe::CreateLocalProxy()?
> That would avoid the repeating of MessagePipe in the above line.
> 
> It looks like all constructor calls are heap allocations of the form "new
> MessagePipe(MessagePipe::Blah)"

I thought about it, and decided not to do it for some unknown reason. Let me
reconsider....

[viettrungluu, 2014-08-25 22:26:28]

Okay, updated. PTAL.

[darin (slow to review), 2014-08-25 23:04:28]

LGTM

[viettrungluu, 2014-08-25 23:12:48]

The CQ bit was checked by viettrungluu@chromium.org

[commit-bot: I haz the power, 2014-08-25 23:14:10]

CQ is trying da patch. Follow status at

https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/505863002/40001

[commit-bot: I haz the power, 2014-08-26 00:43:09]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[commit-bot: I haz the power, 2014-08-26 01:43:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-26 01:43:23]

Failed to commit the patch.

[viettrungluu, 2014-08-26 16:59:57]

Committed patchset #3 to pending queue manually as 1edc87f (presubmit
successful).

[commit-bot: I haz the power, 2014-09-10 02:43:20]

Patchset 3 (id:??) landed as
https://crrev.com/f830881ad8712d8f2baacf69ff97f1069ca9d976
Cr-Commit-Position: refs/heads/master@{#291919}