Issue 505353002: Reduce input dependencies in GN.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 505353002: Reduce input dependencies in GN. (Closed)

Created:
6 years, 3 months ago by brettw

Modified:
6 years, 3 months ago

Reviewers:
scottmg

CC:
chromium-reviews, tfarina

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Committed: https://crrev.com/a4e40580295162832bd577de0e7f06f1c62df343 Cr-Commit-Position: refs/heads/master@{#292003}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+106 lines, -37 lines)			Patch
M	tools/gn/ninja_action_target_writer.h	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	tools/gn/ninja_action_target_writer.cc	View	5 chunks	+20 lines, -5 lines	0 comments	Download
M	tools/gn/ninja_binary_target_writer.cc	View	3 chunks	+42 lines, -2 lines	0 comments	Download
M	tools/gn/ninja_binary_target_writer_unittest.cc	View	2 chunks	+19 lines, -4 lines	0 comments	Download
M	tools/gn/ninja_target_writer.h	View	2 chunks	+6 lines, -6 lines	0 comments	Download
M	tools/gn/ninja_target_writer.cc	View	5 chunks	+7 lines, -8 lines	0 comments	Download
M	tools/gn/ninja_target_writer_unittest.cc	View	5 chunks	+9 lines, -9 lines	0 comments	Download

Total messages: 5 (0 generated)

brettw

brettw@chromium.org changed reviewers: + scottmg@chromium.org

6 years, 3 months ago (2014-08-26 20:23:13 UTC) #1

brettw

Committed patchset #1 to pending queue manually as 8cf97d6 (presubmit successful).

6 years, 3 months ago (2014-08-26 22:31:10 UTC) #4

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 02:46:26 UTC) #5

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/a4e40580295162832bd577de0e7f06f1c62df343
Cr-Commit-Position: refs/heads/master@{#292003}