Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: tools/gn/ninja_target_writer.h

Issue 505353002: Reduce input dependencies in GN. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/ninja_binary_target_writer_unittest.cc ('k') | tools/gn/ninja_target_writer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/ninja_target_writer.h
diff --git a/tools/gn/ninja_target_writer.h b/tools/gn/ninja_target_writer.h
index e2dbd25cc2164be399e3156e7bf4de329e330e78..f67eba533c86e5b28774a465cf0d141448d9d3a4 100644
--- a/tools/gn/ninja_target_writer.h
+++ b/tools/gn/ninja_target_writer.h
@@ -12,6 +12,7 @@
#include "tools/gn/substitution_type.h"
class FileTemplate;
+class OutputFile;
class Settings;
class Target;
@@ -33,12 +34,11 @@ class NinjaTargetWriter {
void WriteSharedVars(const SubstitutionBits& bits);
// Writes to the output stream a stamp rule for input dependencies, and
- // returns the string to be appended to source rules that encodes the
- // order-only dependencies for the current target. This will include the "|"
- // character so can just be appended to the source rules. If there are no
- // implicit dependencies and no extra target dependencies passed in, returns
- // the empty string.
- std::string WriteInputDepsStampAndGetDep(
+ // returns the file to be appended to source rules that encodes the
+ // order-only dependencies for the current target. The returned OutputFile
+ // will be empty if there are no implicit dependencies and no extra target
+ // dependencies passed in.
+ OutputFile WriteInputDepsStampAndGetDep(
const std::vector<const Target*>& extra_hard_deps) const;
// Writes to the output file a final stamp rule for the target that stamps
« no previous file with comments | « tools/gn/ninja_binary_target_writer_unittest.cc ('k') | tools/gn/ninja_target_writer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698