Remove implicit conversions from scoped_refptr to T* in chrome/browser/media_galleries/

Remove implicit conversions from scoped_refptr to T* in chrome/browser/media_galleries/

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610
Committed: https://crrev.com/07aef0e93387ef992facfdb9c22716a400f85c46
Cr-Commit-Position: refs/heads/master@{#291973}

[dcheng, 2014-08-26 18:19:49]

dcheng@chromium.org changed reviewers:
+ gbillock@chromium.org

[dcheng, 2014-08-26 18:19:49]

Unfortunately, we can't make scoped_refptr testable until the conversion
operator has been removed. While it would be possible to disable the conversion
operator and make it testable in the same patch, the automated tool tries to
skip rewriting code where manual cleanups would be useful. This includes things
like:

// What if ReturnsScopedRefPtr() creates a new object internally?
if (ReturnsScopedRefPtr())

Foo* Bar() {
  const scoped_refptr<Foo>& f = ReturnsScopedRefPtr();
  return f;  // Does the return type need to be rewritten? Or is .get() safe?
}

Doing this in one patch would make catching some of these instances (in
particular, a boolean test on a temporary scoped_refptr) more difficult. As a
result, the work is being split into several steps:
Step 1: Rewrite all implicit conversions to be explicit (or rewrite the receiver
type to scoped_refptr<T>, if the tool believes the conversion to be unsafe).
Step 2: Once a platform compiles cleanly without the conversion operator, #ifdef
the conversion operator out.
Step 3: Make scoped_refptr testable on that platform.
Step 4: Remove unnecessary calls to .get().

[tommycli, 2014-08-26 18:28:47]

On 2014/08/26 18:19:49, dcheng (OOO) wrote:
> Unfortunately, we can't make scoped_refptr testable until the conversion
> operator has been removed. While it would be possible to disable the
conversion
> operator and make it testable in the same patch, the automated tool tries to
> skip rewriting code where manual cleanups would be useful. This includes
things
> like:
> 
> // What if ReturnsScopedRefPtr() creates a new object internally?
> if (ReturnsScopedRefPtr())
> 
> Foo* Bar() {
>   const scoped_refptr<Foo>& f = ReturnsScopedRefPtr();
>   return f;  // Does the return type need to be rewritten? Or is .get() safe?
> }
> 
> Doing this in one patch would make catching some of these instances (in
> particular, a boolean test on a temporary scoped_refptr) more difficult. As a
> result, the work is being split into several steps:
> Step 1: Rewrite all implicit conversions to be explicit (or rewrite the
receiver
> type to scoped_refptr<T>, if the tool believes the conversion to be unsafe).
> Step 2: Once a platform compiles cleanly without the conversion operator,
#ifdef
> the conversion operator out.
> Step 3: Make scoped_refptr testable on that platform.
> Step 4: Remove unnecessary calls to .get().

So this is just an intermediary step - and this patch will eventually be
reverted?

[dcheng, 2014-08-26 18:30:20]

On 2014/08/26 at 18:28:47, tommycli wrote:
> On 2014/08/26 18:19:49, dcheng (OOO) wrote:
> > Unfortunately, we can't make scoped_refptr testable until the conversion
> > operator has been removed. While it would be possible to disable the
conversion
> > operator and make it testable in the same patch, the automated tool tries to
> > skip rewriting code where manual cleanups would be useful. This includes
things
> > like:
> > 
> > // What if ReturnsScopedRefPtr() creates a new object internally?
> > if (ReturnsScopedRefPtr())
> > 
> > Foo* Bar() {
> >   const scoped_refptr<Foo>& f = ReturnsScopedRefPtr();
> >   return f;  // Does the return type need to be rewritten? Or is .get()
safe?
> > }
> > 
> > Doing this in one patch would make catching some of these instances (in
> > particular, a boolean test on a temporary scoped_refptr) more difficult. As
a
> > result, the work is being split into several steps:
> > Step 1: Rewrite all implicit conversions to be explicit (or rewrite the
receiver
> > type to scoped_refptr<T>, if the tool believes the conversion to be unsafe).
> > Step 2: Once a platform compiles cleanly without the conversion operator,
#ifdef
> > the conversion operator out.
> > Step 3: Make scoped_refptr testable on that platform.
> > Step 4: Remove unnecessary calls to .get().
> 
> So this is just an intermediary step - and this patch will eventually be
reverted?

No. There are still many callsites where we have to explicitly convert a
scoped_refptr<T> to a T*. It's only the sites where we are doing boolean testing
that will be reverted.

[tommycli, 2014-08-26 19:03:52]

tommycli@chromium.org changed reviewers:
+ tommycli@chromium.org

[tommycli, 2014-08-26 19:03:52]

okay lgtm. thanks!

[dcheng, 2014-08-26 19:09:03]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2014-08-26 19:10:38]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dcheng@chromium.org/505283002/1

[commit-bot: I haz the power, 2014-08-26 20:04:19]

Committed patchset #1 (1) as 3114f13be8905f0e65f275291325aab0d51a1256

[commit-bot: I haz the power, 2014-09-10 02:45:20]

Patchset 1 (id:??) landed as
https://crrev.com/07aef0e93387ef992facfdb9c22716a400f85c46
Cr-Commit-Position: refs/heads/master@{#291973}