chrome/browser/media_galleries/fileapi/mtp_file_stream_reader.cc - Issue 505283002: Remove implicit conversions from scoped_refptr to T* in chrome/browser/media_galleries/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media_galleries/fileapi/mtp_file_stream_reader.cc

Issue 505283002: Remove implicit conversions from scoped_refptr to T* in chrome/browser/media_galleries/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/media_galleries/fileapi/device_media_async_file_util.cc ('k') | chrome/browser/media_galleries/fileapi/readahead_file_stream_reader.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media_galleries/fileapi/mtp_file_stream_reader.cc

diff --git a/chrome/browser/media_galleries/fileapi/mtp_file_stream_reader.cc b/chrome/browser/media_galleries/fileapi/mtp_file_stream_reader.cc

index e79882b4dc6728f6a4c80aa3ad452e8d85cd132c..14c3c81464ada5e70355dec2b6d303dd5092b7b4 100644

--- a/chrome/browser/media_galleries/fileapi/mtp_file_stream_reader.cc

+++ b/chrome/browser/media_galleries/fileapi/mtp_file_stream_reader.cc

@@ -104,10 +104,16 @@ int MTPFileStreamReader::Read(net::IOBuffer* buf, int buf_len,

header_buf_len = net::kMaxBytesToSniff;

}

- ReadBytes(url_, header_buf, 0, header_buf_len,

+ ReadBytes(url_,

+ header_buf.get(),

+ 0,

+ header_buf_len,

base::Bind(&MTPFileStreamReader::FinishValidateMediaHeader,

- weak_factory_.GetWeakPtr(), header_buf,

- make_scoped_refptr(buf), buf_len, callback),

+ weak_factory_.GetWeakPtr(),

+ header_buf,

+ make_scoped_refptr(buf),

+ buf_len,

+ callback),

callback);

return net::ERR_IO_PENDING;

}