Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 505243003: pdf: Move PepperPDFHost into the pdf component. (Closed)

Created:
6 years, 3 months ago by sadrul
Modified:
6 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@pdf-component
Project:
chromium
Visibility:
Public.

Description

Committed: https://crrev.com/a1733ee3921edbf62acd0c8128b4160852997761 Cr-Commit-Position: refs/heads/master@{#292416}

Patch Set 1 #

Total comments: 4

Patch Set 2 : tot-merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -519 lines) Patch
M chrome/chrome_renderer.gypi View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/renderer/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/pepper/chrome_pdf_print_client.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/pepper/chrome_pdf_print_client.cc View 1 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/renderer/pepper/chrome_renderer_pepper_host_factory.cc View 2 chunks +3 lines, -3 lines 0 comments Download
D chrome/renderer/pepper/pepper_pdf_host.h View 1 chunk +0 lines, -85 lines 0 comments Download
D chrome/renderer/pepper/pepper_pdf_host.cc View 1 chunk +0 lines, -392 lines 0 comments Download
M components/pdf.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
M components/pdf/renderer/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
A + components/pdf/renderer/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
A + components/pdf/renderer/pepper_pdf_host.h View 3 chunks +8 lines, -4 lines 0 comments Download
A + components/pdf/renderer/pepper_pdf_host.cc View 4 chunks +9 lines, -21 lines 0 comments Download
M components/pdf/renderer/ppb_pdf_impl.h View 1 2 chunks +5 lines, -4 lines 0 comments Download
M components/pdf/renderer/ppb_pdf_impl.cc View 1 3 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
sadrul
sadrul@chromium.org changed reviewers: + raymes@chromium.org, thestig@chromium.org
6 years, 3 months ago (2014-08-26 19:39:30 UTC) #1
sadrul
Hi! This is the follow-up patch from https://codereview.chromium.org/477263003/ to move PepperPDFHost into the pdf component.
6 years, 3 months ago (2014-08-26 19:39:31 UTC) #2
Lei Zhang
Looking... Can you add an OWNERS file, and also a README file to describe what ...
6 years, 3 months ago (2014-08-26 21:52:48 UTC) #3
Lei Zhang
https://codereview.chromium.org/505243003/diff/1/chrome/renderer/DEPS File chrome/renderer/DEPS (right): https://codereview.chromium.org/505243003/diff/1/chrome/renderer/DEPS#newcode15 chrome/renderer/DEPS:15: "+components/pdf/renderer", Your CL diff is funny. Upstream chrome/renderer/DEPS doesn't ...
6 years, 3 months ago (2014-08-26 21:58:26 UTC) #4
Lei Zhang
Just to confirm, this is intended to be the first CL in a series, right? ...
6 years, 3 months ago (2014-08-26 22:00:49 UTC) #5
sadrul
On 2014/08/26 22:00:49, Lei Zhang wrote: > Just to confirm, this is intended to be ...
6 years, 3 months ago (2014-08-26 22:18:31 UTC) #6
raymes
On 2014/08/26 21:58:26, Lei Zhang wrote: > https://codereview.chromium.org/505243003/diff/1/chrome/renderer/DEPS > File chrome/renderer/DEPS (right): > > https://codereview.chromium.org/505243003/diff/1/chrome/renderer/DEPS#newcode15 ...
6 years, 3 months ago (2014-08-27 00:50:01 UTC) #7
sadrul
https://codereview.chromium.org/505243003/diff/1/components/pdf/renderer/ppb_pdf_impl.cc File components/pdf/renderer/ppb_pdf_impl.cc (right): https://codereview.chromium.org/505243003/diff/1/components/pdf/renderer/ppb_pdf_impl.cc#newcode326 components/pdf/renderer/ppb_pdf_impl.cc:326: PPB_PDF_Impl::InvokePrintingForInstance(instance); On 2014/08/26 21:58:26, Lei Zhang wrote: > Why ...
6 years, 3 months ago (2014-08-27 01:05:15 UTC) #8
raymes
Ah right, sorry I missed that. lgtm On Wed, Aug 27, 2014 at 11:05 AM, ...
6 years, 3 months ago (2014-08-27 01:15:26 UTC) #9
raymes
lgtm
6 years, 3 months ago (2014-08-27 01:16:21 UTC) #10
raymes
Also, you may want to manually test that invoking printing from PDF works correctly (in ...
6 years, 3 months ago (2014-08-27 01:16:31 UTC) #11
sadrul
The first patch has landed. This is now ready to land too. On 2014/08/27 01:16:31, ...
6 years, 3 months ago (2014-08-28 15:47:02 UTC) #12
sadrul
sadrul@chromium.org changed reviewers: + senorblanco@chromium.org, sky@chromium.org
6 years, 3 months ago (2014-08-28 16:23:19 UTC) #13
sadrul
+sky@ for added DEPS on ui/gfx/ from components/pdf/renderer +senorblanco@ for added DEPS on skia/ext from ...
6 years, 3 months ago (2014-08-28 16:23:19 UTC) #14
sky
LGTM
6 years, 3 months ago (2014-08-28 16:31:00 UTC) #15
Stephen White
LGTM (although I don't think my approval has any magical powers in this case).
6 years, 3 months ago (2014-08-28 16:34:59 UTC) #16
Lei Zhang
lgtm
6 years, 3 months ago (2014-08-28 16:51:51 UTC) #17
sadrul
Committed patchset #2 (id:20001) to pending queue manually as f255c6d (presubmit successful).
6 years, 3 months ago (2014-08-28 18:20:27 UTC) #18
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:00:40 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a1733ee3921edbf62acd0c8128b4160852997761
Cr-Commit-Position: refs/heads/master@{#292416}

Powered by Google App Engine
This is Rietveld 408576698