pdf: Move PepperPDFHost into the pdf component.

components/pdf/renderer/ppb_pdf_impl.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/pdf/renderer/ppb_pdf_impl.h"
 
 #include "base/files/scoped_file.h"
 #include "base/metrics/histogram.h"
 #include "base/numerics/safe_conversions.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 304 matching lines @@
 
   content::RenderView* render_view = instance->GetRenderView();
   blink::WebLocalFrame* frame =
       render_view->GetWebView()->mainFrame()->toWebLocalFrame();
   content::Referrer referrer(frame->document().url(),
                              frame->document().referrerPolicy());
   render_view->Send(
       new PDFHostMsg_PDFSaveURLAs(render_view->GetRoutingID(), url, referrer));
 }
 
+void Print(PP_Instance instance) {
+  PPB_PDF_Impl::InvokePrintingForInstance(instance);

[Lei Zhang, 2014/08/26 21:58:26]

Why do we bother making InvokePrintingForInstance() return a bool when we don't
actually care about the return results?

[sadrul, 2014/08/27 01:05:15]

The return value is used in PepperPDFHost::OnHostMsgPrint() to determine whether
to return PP_OK or PP_ERROR_FAILED

+}
+
 PP_Bool IsFeatureEnabled(PP_Instance instance, PP_PDFFeature feature) {
   switch (feature) {
     case PP_PDFFEATURE_HIDPI:
       return PP_TRUE;
     case PP_PDFFEATURE_PRINTING:
       return (print_delegate && print_delegate->IsPrintingEnabled(instance))
                  ? PP_TRUE
                  : PP_FALSE;
   }
   return PP_FALSE;
@@ skipping 74 matching lines @@
     &GetFontFileWithFallback,                  //
     &GetFontTableForPrivateFontFile,           //
     &SearchString,                             //
     &DidStartLoading,                          //
     &DidStopLoading,                           //
     &SetContentRestriction,                    //
     &HistogramPDFPageCount,                    //
     &UserMetricsRecordAction,                  //
     &HasUnsupportedFeature,                    //
     &SaveAs,                                   //
-    &PPB_PDF_Impl::InvokePrintingForInstance,  //
+    &Print,                                    //
     &IsFeatureEnabled,                         //
     &GetResourceImageForScale,                 //
     &ModalPromptForPassword,                   //
     &IsOutOfProcess,                           //
     &SetSelectedText,                          //
     &SetLinkUnderCursor,                       //
 };
 
 }  // namespace
 
 // static
 const PPB_PDF* PPB_PDF_Impl::GetInterface() {
   return &ppb_pdf;
 }
 
 // static
-void PPB_PDF_Impl::InvokePrintingForInstance(PP_Instance instance_id) {
-  if (print_delegate)
-    print_delegate->Print(instance_id);
+bool PPB_PDF_Impl::InvokePrintingForInstance(PP_Instance instance_id) {
+  return print_delegate ? print_delegate->Print(instance_id) : false;
 }
 
 void PPB_PDF_Impl::SetPrintDelegate(PPB_PDF_Impl::PrintDelegate* delegate) {
   CHECK(!print_delegate) << "There should only be a single PrintDelegate.";
   print_delegate = delegate;
 }
 
 }  // namespace pdf