Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 505233004: Remove implicit conversions from scoped_refptr to T* in chrome/browser/password_manager/ (Closed)

Created:
6 years, 3 months ago by dcheng
Modified:
6 years, 3 months ago
Reviewers:
albertb, Garrett Casto
CC:
chromium-reviews, gcasto+watchlist_chromium.org, mkwst+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove implicit conversions from scoped_refptr to T* in chrome/browser/password_manager/ This patch was generated by running the rewrite_scoped_refptr clang tool on a Linux build. BUG=110610 Committed: https://crrev.com/a9be894f9dbc0eb24f53bfd54a9e6d009426b5b9 Cr-Commit-Position: refs/heads/master@{#291972}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M chrome/browser/password_manager/mock_password_store_service.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/password_manager/password_store_factory.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/password_manager/test_password_store_service.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
dcheng
dcheng@chromium.org changed reviewers: + albertb@chromium.org
6 years, 3 months ago (2014-08-26 18:23:16 UTC) #1
dcheng
Unfortunately, we can't make scoped_refptr testable until the conversion operator has been removed. While it ...
6 years, 3 months ago (2014-08-26 18:23:16 UTC) #2
albertb
Hi there, I haven't committed anything significant to chromium in years. I probably shouldn't be ...
6 years, 3 months ago (2014-08-26 18:25:32 UTC) #3
dcheng
dcheng@chromium.org changed reviewers: + gcasto@chromium.org
6 years, 3 months ago (2014-08-26 18:31:45 UTC) #4
dcheng
+gcasto, mind taking a look?
6 years, 3 months ago (2014-08-26 18:31:45 UTC) #5
Garrett Casto
lgtm
6 years, 3 months ago (2014-08-26 18:35:07 UTC) #6
dcheng
The CQ bit was checked by dcheng@chromium.org
6 years, 3 months ago (2014-08-26 18:36:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/505233004/1
6 years, 3 months ago (2014-08-26 18:38:11 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel_swarming on tryserver.chromium.win ...
6 years, 3 months ago (2014-08-26 19:28:18 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (1) as b3906a63a429ee89e212ee2800e0cf7cb6913431
6 years, 3 months ago (2014-08-26 20:03:58 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:45:18 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a9be894f9dbc0eb24f53bfd54a9e6d009426b5b9
Cr-Commit-Position: refs/heads/master@{#291972}

Powered by Google App Engine
This is Rietveld 408576698