chrome/browser/password_manager/password_store_factory.cc - Issue 505233004: Remove implicit conversions from scoped_refptr to T* in chrome/browser/password_manager/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/password_store_factory.cc

Issue 505233004: Remove implicit conversions from scoped_refptr to T* in chrome/browser/password_manager/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/mock_password_store_service.cc ('k') | chrome/browser/password_manager/test_password_store_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/password_store_factory.cc

diff --git a/chrome/browser/password_manager/password_store_factory.cc b/chrome/browser/password_manager/password_store_factory.cc

index 41c95ca6a6ec3ea2abec55a617b6ccded5634563..6503a209300cdb0662f8723f69a0a20a82fb6c22 100644

--- a/chrome/browser/password_manager/password_store_factory.cc

+++ b/chrome/browser/password_manager/password_store_factory.cc

@@ -62,7 +62,7 @@ scoped_refptr<PasswordStore> PasswordStoreService::GetPasswordStore() {

}

void PasswordStoreService::Shutdown() {

- if (password_store_)

+ if (password_store_.get())

password_store_->Shutdown();

}

@@ -229,9 +229,9 @@ KeyedService* PasswordStoreFactory::BuildServiceInstanceFor(

#endif

std::string sync_username =

password_manager_sync_metrics::GetSyncUsername(profile);

- if (!ps || !ps->Init(

- sync_start_util::GetFlareForSyncableService(profile->GetPath()),

- sync_username)) {

+ if (!ps.get() ||

+ !ps->Init(sync_start_util::GetFlareForSyncableService(profile->GetPath()),

+ sync_username)) {

NOTREACHED() << "Could not initialize password manager.";

return NULL;

}