Add UMA to study the video types for mobile

content/browser/media/android/browser_media_player_manager.cc

Index: content/browser/media/android/browser_media_player_manager.cc
diff --git a/content/browser/media/android/browser_media_player_manager.cc b/content/browser/media/android/browser_media_player_manager.cc
index c847a275b8f37d484775164dd90079ab69a135e7..bafbfee3a96c334c37dd2e4008584bd6effec02f 100644
--- a/content/browser/media/android/browser_media_player_manager.cc
+++ b/content/browser/media/android/browser_media_player_manager.cc
@@ -6,6 +6,7 @@
 
 #include "base/android/scoped_java_ref.h"
 #include "base/command_line.h"
+#include "base/metrics/histogram.h"
 #include "content/browser/android/content_view_core_impl.h"
 #include "content/browser/media/android/browser_demuxer_android.h"
 #include "content/browser/media/android/media_resource_getter_impl.h"
@@ -40,6 +41,12 @@ namespace content {
 // attempting to release inactive media players.
 const int kMediaPlayerThreshold = 1;
 
+enum MediaType {
+  NON_HTTP_LIVE_STREAM_TYPE = 0,
+  // Match the value in histograms.xml
+  HTTP_LIVE_STREAM_TYPE = 22,
+};
+
 static BrowserMediaPlayerManager::Factory g_factory = NULL;
 static media::MediaUrlInterceptor* media_url_interceptor_ = NULL;
 
@@ -71,6 +78,9 @@ MediaPlayerAndroid* BrowserMediaPlayerManager::CreateMediaPlayer(
     bool hide_url_log,
     MediaPlayerManager* manager,
     BrowserDemuxerAndroid* demuxer) {
+  UMA_HISTOGRAM_BOOLEAN(

[scherkus (not reviewing), 2014/08/28 19:07:28]

any reason why we don't log these UMAs when WebMediaPlayerAndroid::load() is
called, similar to WebMediaPlayerImpl?

[qinmin, 2014/08/28 20:43:40]

Done. Moved it to WMPA.

+      "Media.MSE.Playback",
+      media_player_params.type == MEDIA_PLAYER_TYPE_MEDIA_SOURCE);
   switch (media_player_params.type) {
     case MEDIA_PLAYER_TYPE_URL: {
       const std::string user_agent = GetContentClient()->GetUserAgent();
@@ -103,6 +113,13 @@ MediaPlayerAndroid* BrowserMediaPlayerManager::CreateMediaPlayer(
             media_player_params.url)) {
         media_player_bridge->Initialize();
       }
+      std::string path = media_player_params.url.path();
+      bool is_hls_media = EndsWith(path, ".m3u8", true) ||
+          EndsWith(path, ".m3u", true);
+      MediaType media_type = is_hls_media ? HTTP_LIVE_STREAM_TYPE :
+          NON_HTTP_LIVE_STREAM_TYPE;
+      UMA_HISTOGRAM_ENUMERATION(
+          "Media.DetectedContainer", media_type, HTTP_LIVE_STREAM_TYPE + 1);

[scherkus (not reviewing), 2014/08/28 19:07:28]

to be honest I don't think it's worth reusing this particular histogram as
you're:
  a) redefining a subset of the enum it uses
  b) detecting the type based on URL suffix rather than how
Media.DetectedContainer currently detects the type by inspecting bytes

considering this is Android specific, I'd by fine having a histogram for
answering the question "Is this an HLS stream or not?"


also same question as above w.r.t. doing this inside of
WebMediaPlayerAndroid::load() -- we already have a IsHLSStream() method there :)

[qinmin, 2014/08/28 20:43:40]

Done.

       return media_player_bridge;
     }