Add UMA to study the video types for mobile

content/browser/media/android/browser_media_player_manager.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/media/android/browser_media_player_manager.h"
 
 #include "base/android/scoped_java_ref.h"
 #include "base/command_line.h"
+#include "base/metrics/histogram.h"
 #include "content/browser/android/content_view_core_impl.h"
 #include "content/browser/media/android/browser_demuxer_android.h"
 #include "content/browser/media/android/media_resource_getter_impl.h"
 #include "content/browser/renderer_host/render_view_host_impl.h"
 #include "content/browser/web_contents/web_contents_view_android.h"
 #include "content/common/media/media_player_messages_android.h"
 #include "content/public/browser/android/content_view_core.h"
 #include "content/public/browser/android/external_video_surface_container.h"
 #include "content/public/browser/browser_context.h"
 #include "content/public/browser/content_browser_client.h"
@@ skipping 14 matching lines @@
 using media::MediaPlayerBridge;
 using media::MediaPlayerManager;
 using media::MediaSourcePlayer;
 
 namespace content {
 
 // Threshold on the number of media players per renderer before we start
 // attempting to release inactive media players.
 const int kMediaPlayerThreshold = 1;
 
+enum MediaType {
+  NON_HTTP_LIVE_STREAM_TYPE = 0,
+  // Match the value in histograms.xml
+  HTTP_LIVE_STREAM_TYPE = 22,
+};
+
 static BrowserMediaPlayerManager::Factory g_factory = NULL;
 static media::MediaUrlInterceptor* media_url_interceptor_ = NULL;
 
 // static
 void BrowserMediaPlayerManager::RegisterFactory(Factory factory) {
   g_factory = factory;
 }
 
 // static
 void BrowserMediaPlayerManager::RegisterMediaUrlInterceptor(
@@ skipping 11 matching lines @@
 
 ContentViewCoreImpl* BrowserMediaPlayerManager::GetContentViewCore() const {
   return ContentViewCoreImpl::FromWebContents(web_contents());
 }
 
 MediaPlayerAndroid* BrowserMediaPlayerManager::CreateMediaPlayer(
     const MediaPlayerHostMsg_Initialize_Params& media_player_params,
     bool hide_url_log,
     MediaPlayerManager* manager,
     BrowserDemuxerAndroid* demuxer) {
+  UMA_HISTOGRAM_BOOLEAN(

[scherkus (not reviewing), 2014/08/28 19:07:28]

any reason why we don't log these UMAs when WebMediaPlayerAndroid::load() is
called, similar to WebMediaPlayerImpl?

[qinmin, 2014/08/28 20:43:40]

Done. Moved it to WMPA.

+      "Media.MSE.Playback",
+      media_player_params.type == MEDIA_PLAYER_TYPE_MEDIA_SOURCE);
   switch (media_player_params.type) {
     case MEDIA_PLAYER_TYPE_URL: {
       const std::string user_agent = GetContentClient()->GetUserAgent();
       MediaPlayerBridge* media_player_bridge = new MediaPlayerBridge(
           media_player_params.player_id,
           media_player_params.url,
           media_player_params.first_party_for_cookies,
           user_agent,
           hide_url_log,
           manager,
@@ skipping 12 matching lines @@
         // May reach here due to prerendering. Don't extract the metadata
         // since it is expensive.
         // TODO(qinmin): extract the metadata once the user decided to load
         // the page.
         browser_media_player_manager->OnMediaMetadataChanged(
             media_player_params.player_id, base::TimeDelta(), 0, 0, false);
       } else if (!content_view_core_impl->ShouldBlockMediaRequest(
             media_player_params.url)) {
         media_player_bridge->Initialize();
       }
+      std::string path = media_player_params.url.path();
+      bool is_hls_media = EndsWith(path, ".m3u8", true) ||
+          EndsWith(path, ".m3u", true);
+      MediaType media_type = is_hls_media ? HTTP_LIVE_STREAM_TYPE :
+          NON_HTTP_LIVE_STREAM_TYPE;
+      UMA_HISTOGRAM_ENUMERATION(
+          "Media.DetectedContainer", media_type, HTTP_LIVE_STREAM_TYPE + 1);

[scherkus (not reviewing), 2014/08/28 19:07:28]

to be honest I don't think it's worth reusing this particular histogram as
you're:
  a) redefining a subset of the enum it uses
  b) detecting the type based on URL suffix rather than how
Media.DetectedContainer currently detects the type by inspecting bytes

considering this is Android specific, I'd by fine having a histogram for
answering the question "Is this an HLS stream or not?"


also same question as above w.r.t. doing this inside of
WebMediaPlayerAndroid::load() -- we already have a IsHLSStream() method there :)

[qinmin, 2014/08/28 20:43:40]

Done.

       return media_player_bridge;
     }
 
     case MEDIA_PLAYER_TYPE_MEDIA_SOURCE: {
       return new MediaSourcePlayer(
           media_player_params.player_id,
           manager,
           base::Bind(&BrowserMediaPlayerManager::OnMediaResourcesRequested,
                      weak_ptr_factory_.GetWeakPtr()),
           base::Bind(&BrowserMediaPlayerManager::OnMediaResourcesReleased,
@@ skipping 470 matching lines @@
 #if defined(VIDEO_HOLE)
   MediaPlayerAndroid* player = GetPlayer(player_id);
   if (player && player->IsSurfaceInUse())
     return;
   if (external_video_surface_container_)
     external_video_surface_container_->ReleaseExternalVideoSurface(player_id);
 #endif  // defined(VIDEO_HOLE)
 }
 
 }  // namespace content