Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 505133003: Introduce subclass wrappers for STL containers that make them a lot easier (Closed)

Created:
6 years, 3 months ago by titzer
Modified:
6 years, 3 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Introduce subclass wrappers for STL containers that make them a lot easier to use with Zone. For example, subclasses add constructors that wrap a Zone in a zone_allocator to save clients this verbosity. R=bmeurer@chromium.org, mstarzinger@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=23402

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -156 lines) Patch
M src/compiler/code-generator.h View 1 chunk +3 lines, -11 lines 0 comments Download
M src/compiler/code-generator.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M src/compiler/generic-algorithm.h View 2 chunks +3 lines, -5 lines 0 comments Download
M src/compiler/generic-node.h View 2 chunks +2 lines, -8 lines 0 comments Download
M src/compiler/generic-node-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/graph.h View 1 chunk +2 lines, -4 lines 0 comments Download
M src/compiler/graph.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M src/compiler/graph-builder.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/graph-reducer.h View 2 chunks +2 lines, -6 lines 0 comments Download
M src/compiler/graph-reducer.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M src/compiler/instruction.h View 3 chunks +9 lines, -15 lines 0 comments Download
M src/compiler/instruction-selector.h View 1 chunk +1 line, -4 lines 0 comments Download
M src/compiler/instruction-selector.cc View 3 chunks +8 lines, -9 lines 0 comments Download
M src/compiler/js-inlining.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/node.h View 2 chunks +4 lines, -11 lines 0 comments Download
M src/compiler/node-aux-data.h View 2 chunks +2 lines, -7 lines 0 comments Download
M src/compiler/node-aux-data-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/raw-machine-assembler.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/compiler/schedule.h View 3 chunks +6 lines, -7 lines 0 comments Download
M src/compiler/scheduler.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/compiler/scheduler.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 3 chunks +4 lines, -9 lines 0 comments Download
M src/compiler/structured-machine-assembler.h View 3 chunks +4 lines, -10 lines 0 comments Download
M src/compiler/structured-machine-assembler.cc View 4 chunks +9 lines, -12 lines 0 comments Download
M src/compiler/verifier.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/zone-containers.h View 2 chunks +40 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
titzer
6 years, 3 months ago (2014-08-26 10:57:53 UTC) #1
Michael Starzinger
LGTM (but I am not a STL-ninja).
6 years, 3 months ago (2014-08-26 11:13:44 UTC) #2
Benedikt Meurer
lgtm
6 years, 3 months ago (2014-08-26 11:34:06 UTC) #3
titzer
6 years, 3 months ago (2014-08-26 13:09:37 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 manually as 23402 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698