Revert "Revert of Hook up the Mac password bubble to the browser and add browser tests. (patchset #…

Revert "Revert of Hook up the Mac password bubble to the browser and add browser tests. (patchset #8 of https://codereview.chromium.org/444603003/)"

This reverts commit e8e38740e5ab846889016636024309473c04dedd and fixes
the flakiness of the tests.

The fix is in patch set #2: when the icon is deleted before the bubble, it
clears the icon pointer in the bubble.

Ran five times on the bots without causing failures.

BUG=328847
TBR=vabr@chromium.org,shess@chromium.org,sky@chromium.org

Committed: https://crrev.com/8d7bdba36d40ad26e2f8e13fb613593838f4e1f5
Cr-Commit-Position: refs/heads/master@{#292618}

[dconnelly, 2014-08-28 09:52:22]

Patchset #2 (id:20001) has been deleted

[dconnelly, 2014-08-28 09:57:01]

Patchset #1 (id:1) has been deleted

[dconnelly, 2014-08-28 09:58:23]

Patchset #2 (id:60001) has been deleted

[dconnelly, 2014-08-28 10:01:10]

Patchset #2 (id:80001) has been deleted

[dconnelly, 2014-08-28 13:39:42]

dconnelly@chromium.org changed reviewers:
+ rohitrao@chromium.org

[dconnelly, 2014-08-28 13:40:43]

Hi Rohit: this is a re-land. The previous reviewer is now OOO. The fix is in
patch set #2.

[dconnelly, 2014-08-28 13:41:55]

dconnelly@chromium.org changed reviewers:
+ shess@chromium.org, vabr@chromium.org

[dconnelly, 2014-08-28 13:42:48]

dconnelly@chromium.org changed reviewers:
+ sky@chromium.org

[rohitrao (ping after 24h), 2014-08-28 15:20:25]

Diff from PS1 LGTM

[rohitrao (ping after 24h), 2014-08-28 15:20:53]

The CQ bit was checked by rohitrao@chromium.org

[commit-bot: I haz the power, 2014-08-28 15:21:48]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dconnelly@chromium.org/505123002/100001

[dconnelly, 2014-08-28 15:36:04]

The CQ bit was checked by dconnelly@chromium.org

[commit-bot: I haz the power, 2014-08-28 15:36:45]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dconnelly@chromium.org/505123002/120001

[dconnelly, 2014-08-28 16:01:07]

The CQ bit was checked by dconnelly@chromium.org

[commit-bot: I haz the power, 2014-08-28 16:02:08]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dconnelly@chromium.org/505123002/140001

[commit-bot: I haz the power, 2014-08-28 16:55:53]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-28 17:04:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-28 17:04:05]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[dconnelly, 2014-08-29 07:59:56]

The CQ bit was checked by dconnelly@chromium.org

[commit-bot: I haz the power, 2014-08-29 08:00:22]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dconnelly@chromium.org/505123002/160001

[commit-bot: I haz the power, 2014-08-29 13:24:53]

Committed patchset #5 (id:160001) as 55d580953c64ef7aee1140ae5b0542e22572be16

[Scott Hess - ex-Googler, 2014-09-08 17:34:15]

yeah, fix LGTM.

[commit-bot: I haz the power, 2014-09-10 03:08:06]

Patchset 5 (id:??) landed as
https://crrev.com/8d7bdba36d40ad26e2f8e13fb613593838f4e1f5
Cr-Commit-Position: refs/heads/master@{#292618}

[vabr (Chromium), 2014-09-18 07:59:09]

After clarification from Daniel, I understood that the fix is the diff of patch
set 2 against patch set 1, which LGTM.
If the CL weren't landed already, I would suggest changing
SetIcon(ManagePasswordsIcon* icon) to ClearIcon(), because SetIcon is not called
with anything but NULL at the moment, but that's a fairly minor point, and I
explicitly don't require that to be changed post-landing.

Cheers,
Vaclav