chrome/browser/ui/cocoa/location_bar/manage_passwords_decoration_unittest.mm - Issue 505123002: Revert "Revert of Hook up the Mac password bubble to the browser and add browser tests. (patchset #…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/location_bar/manage_passwords_decoration_unittest.mm

Issue 505123002: Revert "Revert of Hook up the Mac password bubble to the browser and add browser tests. (patchset #… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix include for real this time Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/location_bar/manage_passwords_decoration.mm ('k') | chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_browsertest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/location_bar/manage_passwords_decoration_unittest.mm

diff --git a/chrome/browser/ui/cocoa/location_bar/manage_passwords_decoration_unittest.mm b/chrome/browser/ui/cocoa/location_bar/manage_passwords_decoration_unittest.mm

index f49641a23e09b13164042bf23c64be774470b8bb..37a09360af5c5cbbcfdc930f8f4aaa90a3bd40ac 100644

--- a/chrome/browser/ui/cocoa/location_bar/manage_passwords_decoration_unittest.mm

+++ b/chrome/browser/ui/cocoa/location_bar/manage_passwords_decoration_unittest.mm

@@ -53,7 +53,8 @@ bool ImagesEqual(NSImage* left, NSImage* right) {

class ManagePasswordsDecorationTest : public CocoaTest {

public:

ManagePasswordsDecorationTest()

- : commandUpdater_(&commandDelegate_), decoration_(&commandUpdater_) {

+ : commandUpdater_(&commandDelegate_),

+ decoration_(&commandUpdater_, NULL) {

commandUpdater_.UpdateCommandEnabled(IDC_MANAGE_PASSWORDS_FOR_PAGE, true);

}

@@ -69,7 +70,7 @@ class ManagePasswordsDecorationTest : public CocoaTest {

TEST_F(ManagePasswordsDecorationTest, ExecutesManagePasswordsCommandOnClick) {

EXPECT_TRUE(decoration()->AcceptsMousePress());

- EXPECT_TRUE(decoration()->OnMousePressed(NSRect(), NSPoint()));

+ EXPECT_FALSE(decoration()->OnMousePressed(NSRect(), NSPoint()));

EXPECT_EQ(IDC_MANAGE_PASSWORDS_FOR_PAGE, commandDelegate()->id());

}