Fix a bug where the resource manager displays Chrome Apps with non-human readable names.

Fix a bug where the resource manager displays Chrome Apps with non-human readable names.

i.e. "chrome-extension://<id>" instead of "Chrome Dev Editor"

BUG=407451
Committed: https://crrev.com/eb08cced4cf6c7d271dd506a13cb889aaa6d45ad
Cr-Commit-Position: refs/heads/master@{#291953}

[Daniel Nishi, 2014-08-26 01:25:46]

Patchset #1 (id:1) has been deleted

[Daniel Nishi, 2014-08-26 01:26:50]

dhnishi@chromium.org changed reviewers:
+ bauerb@chromium.org

[Daniel Nishi, 2014-08-26 01:26:50]

bauerb: PTAL when you get a moment.

[Bernhard Bauer, 2014-08-26 07:44:31]

https://codereview.chromium.org/505073002/diff/20001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/options/website_settings_handler.cc (right):

https://codereview.chromium.org/505073002/diff/20001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/options/website_settings_handler.cc:520: if
(!extension_service)
When is this NULL?

https://codereview.chromium.org/505073002/diff/20001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/options/website_settings_handler.cc:525: if (!extension)
And this?

[Daniel Nishi, 2014-08-26 17:22:33]

https://codereview.chromium.org/505073002/diff/20001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/options/website_settings_handler.cc (right):

https://codereview.chromium.org/505073002/diff/20001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/options/website_settings_handler.cc:520: if
(!extension_service)
On 2014/08/26 07:44:31, Bernhard Bauer wrote:
> When is this NULL?

Hmm. Looking at it, it looks like this situation shouldn't be possible. I think
the only situation it occurs in normally is when there is a unittest mocking out
part of the ExtensionSystem, but I don't think that situation would occur for a
WebUI part of the code.

I've removed the check.

https://codereview.chromium.org/505073002/diff/20001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/options/website_settings_handler.cc:525: if (!extension)
On 2014/08/26 07:44:31, Bernhard Bauer wrote:
> And this?

This is NULL if for some reason an chrome-extension:// address finds itself
recorded and the app no longer exists.

This can occur if the app is removed before any of the auditing is cleared.

[Bernhard Bauer, 2014-08-26 17:25:58]

LGTM w/ a nit:

https://codereview.chromium.org/505073002/diff/20001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/options/website_settings_handler.cc (right):

https://codereview.chromium.org/505073002/diff/20001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/options/website_settings_handler.cc:525: if (!extension)
On 2014/08/26 17:22:33, Daniel Nishi wrote:
> On 2014/08/26 07:44:31, Bernhard Bauer wrote:
> > And this?
> 
> This is NULL if for some reason an chrome-extension:// address finds itself
> recorded and the app no longer exists.
> 
> This can occur if the app is removed before any of the auditing is cleared.

Makes sense. Can you add a comment that explains this?

[Daniel Nishi, 2014-08-26 17:48:54]

Thanks for the quick reviews, BTW! :)

https://codereview.chromium.org/505073002/diff/20001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/options/website_settings_handler.cc (right):

https://codereview.chromium.org/505073002/diff/20001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/options/website_settings_handler.cc:525: if (!extension)
On 2014/08/26 17:25:58, Bernhard Bauer wrote:
> On 2014/08/26 17:22:33, Daniel Nishi wrote:
> > On 2014/08/26 07:44:31, Bernhard Bauer wrote:
> > > And this?
> > 
> > This is NULL if for some reason an chrome-extension:// address finds itself
> > recorded and the app no longer exists.
> > 
> > This can occur if the app is removed before any of the auditing is cleared.
> 
> Makes sense. Can you add a comment that explains this?

Done.

[Daniel Nishi, 2014-08-26 17:49:05]

The CQ bit was checked by dhnishi@chromium.org

[commit-bot: I haz the power, 2014-08-26 17:50:06]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dhnishi@chromium.org/505073002/60001

[commit-bot: I haz the power, 2014-08-26 18:44:43]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_trigger...)

[commit-bot: I haz the power, 2014-08-26 19:09:08]

Committed patchset #3 (60001) as 70d53532f982ff4d903a7b6d073b3aab114fec9d

[commit-bot: I haz the power, 2014-09-10 02:44:31]

Patchset 3 (id:??) landed as
https://crrev.com/eb08cced4cf6c7d271dd506a13cb889aaa6d45ad
Cr-Commit-Position: refs/heads/master@{#291953}