Fix a bug where the resource manager displays Chrome Apps with non-human readable names.

chrome/browser/ui/webui/options/website_settings_handler.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/options/website_settings_handler.h"
 
 #include "apps/app_window_registry.h"
 #include "chrome/browser/content_settings/content_settings_utils.h"
 #include "chrome/browser/content_settings/host_content_settings_map.h"
+#include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_iterator.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "content/public/browser/dom_storage_context.h"
 #include "content/public/browser/storage_partition.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/browser/web_ui.h"
 #include "extensions/browser/extension_registry.h"
+#include "extensions/browser/extension_system.h"
 #include "extensions/common/constants.h"
 #include "extensions/common/extension.h"
 #include "grit/generated_resources.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/l10n/time_format.h"
 #include "ui/base/text/bytes_formatting.h"
 
 namespace {
 
 const int kHttpPort = 80;
@@ skipping 225 matching lines @@
     base::DictionaryValue* origin_entry = new base::DictionaryValue();
     origin_entry->SetDoubleWithoutPathExpansion("usage",
                                                 last_usage.ToDoubleT());
     base::string16 usage_string;
     if (last_usage.ToDoubleT()) {
       usage_string = ui::TimeFormat::Simple(ui::TimeFormat::FORMAT_ELAPSED,
                                             ui::TimeFormat::LENGTH_SHORT,
                                             base::Time::Now() - last_usage);
     }
     origin_entry->SetStringWithoutPathExpansion("usageString", usage_string);
+    origin_entry->SetStringWithoutPathExpansion("readableName",
+                                                GetReadableName(origin_url));
 
     origins.SetWithoutPathExpansion(origin, origin_entry);
   }
 
   web_ui()->CallJavascriptFunction("WebsiteSettingsManager.populateOrigins",
                                    origins);
 }
 
 void WebsiteSettingsHandler::HandleGetOriginInfo(const base::ListValue* args) {
   std::string url;
@@ skipping 170 matching lines @@
     std::string origin = it->origin_url.spec();
 
     if (origin.find(last_filter_) == base::string16::npos)
       continue;
 
     base::DictionaryValue* origin_entry = new base::DictionaryValue();
     origin_entry->SetWithoutPathExpansion(
         "usage", new base::FundamentalValue(static_cast<double>(it->size)));
     origin_entry->SetWithoutPathExpansion(
         "usageString", new base::StringValue(ui::FormatBytes(it->size)));
+    origin_entry->SetStringWithoutPathExpansion(
+        "readableName", GetReadableName(it->origin_url));
     local_storage_map.SetWithoutPathExpansion(origin, origin_entry);
   }
   web_ui()->CallJavascriptFunction("WebsiteSettingsManager.populateOrigins",
                                    local_storage_map);
 }
 
 void WebsiteSettingsHandler::StopOrigin(const GURL& site_url) {
   Profile* profile = Profile::FromWebUI(web_ui());
   if (site_url.SchemeIs(extensions::kExtensionScheme)) {
     const extensions::Extension* extension =
@@ skipping 34 matching lines @@
   dom_storage_context_->DeleteLocalStorage(site_url);
 
   // Load a new BrowsingDataLocalStorageHelper to update.
   local_storage_ = new BrowsingDataLocalStorageHelper(profile);
 
   local_storage_->StartFetching(
       base::Bind(&WebsiteSettingsHandler::OnLocalStorageFetched,
                  weak_ptr_factory_.GetWeakPtr()));
 }
 
+const std::string& WebsiteSettingsHandler::GetReadableName(
+    const GURL& site_url) {
+  if (site_url.SchemeIs(extensions::kExtensionScheme)) {
+    Profile* profile = Profile::FromWebUI(web_ui());
+    ExtensionService* extension_service =
+        extensions::ExtensionSystem::Get(profile)->extension_service();
+    if (!extension_service)

[Bernhard Bauer, 2014/08/26 07:44:31]

When is this NULL?

[Daniel Nishi, 2014/08/26 17:22:33]

Hmm. Looking at it, it looks like this situation shouldn't be possible. I think
the only situation it occurs in normally is when there is a unittest mocking out
part of the ExtensionSystem, but I don't think that situation would occur for a
WebUI part of the code.

I've removed the check.

+      return site_url.spec();
+
+    const extensions::Extension* extension =
+        extension_service->extensions()->GetExtensionOrAppByURL(site_url);
+    if (!extension)

[Bernhard Bauer, 2014/08/26 07:44:31]

And this?

[Daniel Nishi, 2014/08/26 17:22:33]

This is NULL if for some reason an chrome-extension:// address finds itself
recorded and the app no longer exists.

This can occur if the app is removed before any of the auditing is cleared.

[Bernhard Bauer, 2014/08/26 17:25:58]

Makes sense. Can you add a comment that explains this?

[Daniel Nishi, 2014/08/26 17:48:54]

Done.

+      return site_url.spec();
+
+    return extension->name();
+  }
+  return site_url.spec();
+}
+
 }  // namespace options