Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(755)

Issue 504933002: Fix create OnScreen surface on Mac for compositor_unittests (Closed)

Created:
6 years, 4 months ago by Lof
Modified:
6 years, 3 months ago
Reviewers:
danakj, no sievers, piman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix create OnScreen surface on Mac for compositor_unittests After issue https://codereview.chromium.org/227473009 there is no code for create OnScreen surface for Mac which is using in compositor_unittests. Result: 18 tests crashed: LayerWithDelegateTest.ConvertPointToLayer_Medium LayerWithDelegateTest.ConvertPointToLayer_Simple LayerWithDelegateTest.DelegatedLayer LayerWithDelegateTest.SchedulePaintFromOnPaintLayer LayerWithDelegateTest.SetBoundsWhenInvisible LayerWithNullDelegateTest.SetBoundsSchedulesPaint LayerWithNullDelegateTest.Visibility LayerWithRealCompositorTest.CompositorObservers LayerWithRealCompositorTest.Delegate LayerWithRealCompositorTest.Draw LayerWithRealCompositorTest.DrawPixels LayerWithRealCompositorTest.DrawTree LayerWithRealCompositorTest.Hierarchy LayerWithRealCompositorTest.HierarchyNoTexture LayerWithRealCompositorTest.ModifyHierarchy LayerWithRealCompositorTest.Opacity LayerWithRealCompositorTest.ScaleReparent LayerWithRealCompositorTest.ScaleUpDown If surface is created then all tests passed. R=sievers@chromium.org, ccameron1@chromium.org, danakj@chromium.org TEST=compositor_unittests Committed: https://crrev.com/18499aa5a6af1ee9132436dd3a2fd3cbdb580918 Cr-Commit-Position: refs/heads/master@{#291863}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M ui/gl/gl_surface_mac.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Lof
6 years, 4 months ago (2014-08-25 20:15:23 UTC) #1
Lof
6 years, 4 months ago (2014-08-25 20:18:32 UTC) #2
no sievers
lgtm
6 years, 4 months ago (2014-08-25 20:33:01 UTC) #3
piman
lgtm
6 years, 4 months ago (2014-08-25 20:34:17 UTC) #4
Lof
The CQ bit was checked by lof84@yandex-team.ru
6 years, 4 months ago (2014-08-26 05:22:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lof84@yandex-team.ru/504933002/1
6 years, 4 months ago (2014-08-26 05:24:23 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (1) as 1a7e0399a5e806268cd949d34ed022c1c51c3b1e
6 years, 4 months ago (2014-08-26 07:51:34 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:41:16 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/18499aa5a6af1ee9132436dd3a2fd3cbdb580918
Cr-Commit-Position: refs/heads/master@{#291863}

Powered by Google App Engine
This is Rietveld 408576698