Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 227473009: Mac: Remove NSView support (Closed)

Created:
6 years, 8 months ago by no sievers
Modified:
6 years, 8 months ago
Reviewers:
ccameron
CC:
chromium-reviews
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -266 lines) Patch
M ui/gl/gl.gyp View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/gl/gl_context_mac.mm View 2 chunks +5 lines, -5 lines 0 comments Download
D ui/gl/gl_context_nsview.h View 1 chunk +0 lines, -48 lines 0 comments Download
D ui/gl/gl_context_nsview.mm View 1 chunk +0 lines, -105 lines 0 comments Download
M ui/gl/gl_surface_mac.cc View 1 2 chunks +2 lines, -6 lines 0 comments Download
D ui/gl/gl_surface_nsview.h View 1 chunk +0 lines, -47 lines 0 comments Download
D ui/gl/gl_surface_nsview.mm View 1 chunk +0 lines, -51 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
no sievers
Let's see what the trybots think about this...
6 years, 8 months ago (2014-04-07 21:07:04 UTC) #1
no sievers
Looks promising on mac_chromium_rel and mac_gpu. Anything else I should run?
6 years, 8 months ago (2014-04-07 23:20:18 UTC) #2
ccameron
You may need to run on a debug Mac from the drop-down, but yeah, lgtm
6 years, 8 months ago (2014-04-07 23:21:07 UTC) #3
no sievers
On 2014/04/07 23:21:07, ccameron1 wrote: > You may need to run on a debug Mac ...
6 years, 8 months ago (2014-04-08 22:50:16 UTC) #4
no sievers
The CQ bit was checked by sievers@chromium.org
6 years, 8 months ago (2014-04-08 22:50:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sievers@chromium.org/227473009/10008
6 years, 8 months ago (2014-04-08 22:52:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sievers@chromium.org/227473009/10008
6 years, 8 months ago (2014-04-09 00:31:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sievers@chromium.org/227473009/10008
6 years, 8 months ago (2014-04-09 00:55:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sievers@chromium.org/227473009/10008
6 years, 8 months ago (2014-04-09 01:06:15 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sievers@chromium.org/227473009/10008
6 years, 8 months ago (2014-04-09 01:26:25 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sievers@chromium.org/227473009/10008
6 years, 8 months ago (2014-04-09 01:37:11 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sievers@chromium.org/227473009/10008
6 years, 8 months ago (2014-04-09 01:48:15 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sievers@chromium.org/227473009/10008
6 years, 8 months ago (2014-04-09 01:58:46 UTC) #13
commit-bot: I haz the power
6 years, 8 months ago (2014-04-09 02:07:39 UTC) #14
Message was sent while issue was closed. 
Change committed as 262594

Powered by Google App Engine
This is Rietveld 408576698