Issue 504843003: Public API changes are allowed if an owner is TBR'ed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 504843003: Public API changes are allowed if an owner is TBR'ed (Closed)

Created:
6 years, 3 months ago by rmistry

Modified:
6 years, 3 months ago

Reviewers:
borenet

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Public API changes are allowed if an owner is TBR'ed. The following TBR formats are supported: * TBR=reed * TBR=reed@google.com * TBR=xyz,reed * TBR=xyz,reed@google.com BUG=skia:2870 Committed: https://skia.googlesource.com/skia/+/f2d83caf13afb09deae6355e2f59aa17b7c09058

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -0 lines)			Patch
	M	PRESUBMIT.py	View	1 2	2 chunks	+11 lines, -0 lines	0 comments	Download

Total messages: 6 (0 generated)

rmistry

rmistry@google.com changed reviewers: + borenet@google.com

6 years, 3 months ago (2014-08-26 17:17:50 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/rmistry@google.com/504843003/40001

6 years, 3 months ago (2014-08-26 17:23:12 UTC) #5

commit-bot: I haz the power

6 years, 3 months ago (2014-08-26 17:30:34 UTC) #6

Message was sent while issue was closed.

Committed patchset #3 (40001) as f2d83caf13afb09deae6355e2f59aa17b7c09058