Index: PRESUBMIT.py |
diff --git a/PRESUBMIT.py b/PRESUBMIT.py |
index ebba6092106cc3b41fd9d1b2f35997bfcc0255b7..726983027ce5b65fa935996bc4a87b149038326c 100644 |
--- a/PRESUBMIT.py |
+++ b/PRESUBMIT.py |
@@ -20,6 +20,7 @@ REVERT_CL_SUBJECT_PREFIX = 'Revert ' |
SKIA_TREE_STATUS_URL = 'http://skia-tree-status.appspot.com' |
+# Please add the complete email address here (and not just 'xyz@' or 'xyz'). |
PUBLIC_API_OWNERS = ( |
'reed@chromium.org', |
'reed@google.com', |
@@ -206,6 +207,16 @@ def _CheckLGTMsForPublicAPI(input_api, output_api): |
if re.match(REVERT_CL_SUBJECT_PREFIX, issue_properties['subject'], re.I): |
# It is a revert CL, ignore the public api owners check. |
return results |
+ |
+ match = re.search(r'^TBR=(.*)$', issue_properties['description'], re.M) |
+ if match: |
+ tbr_entries = match.group(1).strip().split(',') |
+ for owner in PUBLIC_API_OWNERS: |
+ if owner in tbr_entries or owner.split('@')[0] in tbr_entries: |
+ # If an owner is specified in the TBR= line then ignore the public |
+ # api owners check. |
+ return results |
+ |
if issue_properties['owner_email'] in PUBLIC_API_OWNERS: |
# An owner created the CL that is an automatic LGTM. |
lgtm_from_owner = True |