Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 504773003: Revert of Fix recursive computation of filter bounds for drop shadow, (Closed)

Created:
6 years, 4 months ago by djsollen
Modified:
6 years, 4 months ago
Reviewers:
bsalomon, Stephen White
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Revert of Fix recursive computation of filter bounds for drop shadow, (patchset #1 of https://codereview.chromium.org/481273005/) Reason for revert: This CL is currently breaking the Win7 and Win8 bots on some of the new tests (in DM). Original issue's description: > Fix recursive computation of filter bounds for drop shadow, > morphology, blur. > > Because we're computing "backwards" from a clip rect of destination > pixels to be filled to the required source pixels, we should use tail > recursion rather than head recursion in onFilterBounds(). > > This actually only makes a difference for drop-shadow, where > the computation is non-commutative. Blur and morphology commute, but I > moved them to tail recursion anyway for clarity (so all onFilterBounds > use tail recursion). > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/28648fe4a69b0cee8df42b5966e4e645c3aabefb TBR=bsalomon@google.com,senorblanco@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/38cb688bd0e17021bb140bbc15ac1a7b8f182939

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -53 lines) Patch
M src/effects/SkBlurImageFilter.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/effects/SkDropShadowImageFilter.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M src/effects/SkMorphologyImageFilter.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/ImageFilterTest.cpp View 1 chunk +0 lines, -44 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
djsollen
Created Revert of Fix recursive computation of filter bounds for drop shadow,
6 years, 4 months ago (2014-08-25 16:05:30 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/djsollen@google.com/504773003/1
6 years, 4 months ago (2014-08-25 16:06:15 UTC) #2
commit-bot: I haz the power
6 years, 4 months ago (2014-08-25 16:06:25 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (1) as 38cb688bd0e17021bb140bbc15ac1a7b8f182939

Powered by Google App Engine
This is Rietveld 408576698