Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1784)

Issue 481273005: Fix recursive computation of filter bounds for drop shadow, (Closed)

Created:
6 years, 4 months ago by Stephen White
Modified:
6 years, 4 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Fix recursive computation of filter bounds for drop shadow, morphology, blur. [Reland with fixed tests.] Because we're computing "backwards" from a clip rect of destination pixels to be filled to the required source pixels, we should use tail recursion rather than head recursion in onFilterBounds(). This actually only makes a difference for drop-shadow, where the computation is non-commutative. Blur and morphology commute, but I moved them to tail recursion anyway for clarity (so all onFilterBounds use tail recursion). BUG=skia: Committed: https://skia.googlesource.com/skia/+/1150a6d151571fb6ee816dadec844ae7ab53948a

Patch Set 1 #

Patch Set 2 : Use an identity matrix for the test, not an uninit one :( #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -9 lines) Patch
M src/effects/SkBlurImageFilter.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/effects/SkDropShadowImageFilter.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M src/effects/SkMorphologyImageFilter.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/ImageFilterTest.cpp View 1 1 chunk +44 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Stephen White
Brian: PTAL. Thanks!
6 years, 4 months ago (2014-08-22 21:59:40 UTC) #1
bsalomon
lgtm
6 years, 4 months ago (2014-08-25 14:22:55 UTC) #2
Stephen White
The CQ bit was checked by senorblanco@chromium.org
6 years, 4 months ago (2014-08-25 14:59:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/senorblanco@chromium.org/481273005/1
6 years, 4 months ago (2014-08-25 15:00:02 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (1) as 28648fe4a69b0cee8df42b5966e4e645c3aabefb
6 years, 4 months ago (2014-08-25 15:07:03 UTC) #5
djsollen
A revert of this CL (patchset #1) has been created in https://codereview.chromium.org/504773003/ by djsollen@google.com. The ...
6 years, 4 months ago (2014-08-25 16:05:29 UTC) #6
Stephen White
Relanding with test fixed.
6 years, 4 months ago (2014-08-25 19:38:07 UTC) #7
Stephen White
The CQ bit was checked by senorblanco@chromium.org
6 years, 4 months ago (2014-08-25 19:38:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/senorblanco@chromium.org/481273005/20001
6 years, 4 months ago (2014-08-25 19:39:19 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-25 19:47:04 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (20001) as 1150a6d151571fb6ee816dadec844ae7ab53948a

Powered by Google App Engine
This is Rietveld 408576698