Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1281)

Issue 50453004: Finding an <object> element by name only works it has no children other than <param> elements (Closed)

Created:
7 years, 1 month ago by Inactive
Modified:
7 years, 1 month ago
CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Finding an <object> element by name only works it has no children other than <param> elements Finding an <object> element by name only works it has no children other than <param> elements. We used to do this to match a very old behavior of IE: https://bugs.webkit.org/show_bug.cgi?id=5449 However, both IE10 and FF24 do not have this restriction anymore. This patch updates our behavior to match IE and FF's, meaning that an <object> element can be found by name even if it has children that are not <param> elements. R=eseidel BUG=313292 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160990

Patch Set 1 #

Patch Set 2 : Rebaseline additional test #

Patch Set 3 : Fix 2 plugins tests #

Total comments: 2

Patch Set 4 : Remove unnecessary include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -68 lines) Patch
M LayoutTests/fast/dom/HTMLDocument/document-special-properties-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/HTMLDocument/object-by-name-or-id.html View 2 chunks +10 lines, -11 lines 0 comments Download
M LayoutTests/fast/dom/HTMLDocument/object-by-name-or-id-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/plugins/embed-inside-object.html View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/plugins/object-embed-plugin-scripting.html View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/plugins/object-embed-plugin-scripting-expected.txt View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLNameCollection.cpp View 1 2 3 2 chunks +1 line, -6 lines 0 comments Download
M Source/core/html/HTMLObjectElement.h View 3 chunks +2 lines, -6 lines 0 comments Download
M Source/core/html/HTMLObjectElement.cpp View 1 2 3 3 chunks +0 lines, -36 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Inactive
7 years, 1 month ago (2013-10-30 16:10:10 UTC) #1
tkent
lgtm https://codereview.chromium.org/50453004/diff/70001/Source/core/html/HTMLNameCollection.cpp File Source/core/html/HTMLNameCollection.cpp (right): https://codereview.chromium.org/50453004/diff/70001/Source/core/html/HTMLNameCollection.cpp#newcode85 Source/core/html/HTMLNameCollection.cpp:85: } else if (current->hasTagName(appletTag) || current->hasTagName(objectTag)) { You ...
7 years, 1 month ago (2013-10-30 21:43:39 UTC) #2
Inactive
https://codereview.chromium.org/50453004/diff/70001/Source/core/html/HTMLNameCollection.cpp File Source/core/html/HTMLNameCollection.cpp (right): https://codereview.chromium.org/50453004/diff/70001/Source/core/html/HTMLNameCollection.cpp#newcode85 Source/core/html/HTMLNameCollection.cpp:85: } else if (current->hasTagName(appletTag) || current->hasTagName(objectTag)) { On 2013/10/30 ...
7 years, 1 month ago (2013-10-30 22:09:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/50453004/130001
7 years, 1 month ago (2013-10-30 22:19:00 UTC) #4
commit-bot: I haz the power
7 years, 1 month ago (2013-10-31 00:09:46 UTC) #5
Message was sent while issue was closed.
Change committed as 160990

Powered by Google App Engine
This is Rietveld 408576698