Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(830)

Unified Diff: Source/core/html/HTMLNameCollection.cpp

Issue 50453004: Finding an <object> element by name only works it has no children other than <param> elements (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Remove unnecessary include Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/HTMLNameCollection.cpp
diff --git a/Source/core/html/HTMLNameCollection.cpp b/Source/core/html/HTMLNameCollection.cpp
index 57a181d65051d2b87c97d9cd5da2c008d65ec7b7..0706e81cb23f32197478caca3cfe5b1fb0b5f20b 100644
--- a/Source/core/html/HTMLNameCollection.cpp
+++ b/Source/core/html/HTMLNameCollection.cpp
@@ -27,7 +27,6 @@
#include "core/dom/Element.h"
#include "core/dom/ElementTraversal.h"
#include "core/dom/NodeRareData.h"
-#include "core/html/HTMLObjectElement.h"
namespace WebCore {
@@ -82,13 +81,9 @@ Element* HTMLNameCollection::virtualItemAfter(unsigned& offsetInArray, Element*
if (current->hasTagName(formTag) || current->hasTagName(embedTag) || current->hasTagName(iframeTag)) {
if (current->getNameAttribute() == m_name)
return current;
- } else if (current->hasTagName(appletTag)) {
+ } else if (current->hasTagName(appletTag) || current->hasTagName(objectTag)) {
if (current->getNameAttribute() == m_name || current->getIdAttribute() == m_name)
return current;
- } else if (current->hasTagName(objectTag)) {
- if ((current->getNameAttribute() == m_name || current->getIdAttribute() == m_name)
- && toHTMLObjectElement(current)->isDocNamedItem())
- return current;
} else if (current->hasTagName(imgTag)) {
if (current->getNameAttribute() == m_name || (current->getIdAttribute() == m_name && current->hasName()))
return current;
« no previous file with comments | « LayoutTests/plugins/object-embed-plugin-scripting-expected.txt ('k') | Source/core/html/HTMLObjectElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698