Move base64-urlsafe helpers to jwk.{cc,h}

Move base64-urlsafe helpers to jwk.{cc,h}

BUG=407858
Committed: https://crrev.com/7ddf94b2bd03be89f9c199f486a843a2c8d4862d
Cr-Commit-Position: refs/heads/master@{#292456}

[eroman, 2014-08-27 00:06:54]

eroman@chromium.org changed reviewers:
+ rsleevi@chromium.org

[Ryan Sleevi, 2014-08-27 17:22:15]

LGTM with nits.

https://codereview.chromium.org/504413004/diff/1/content/child/webcrypto/jwk.cc
File content/child/webcrypto/jwk.cc (right):

https://codereview.chromium.org/504413004/diff/1/content/child/webcrypto/jwk....
content/child/webcrypto/jwk.cc:708: std::string base64EncodedText(input);
1) variable naming / style
2) This still seems to allow invalid Base64URL codings

I'm happy to leave 2 for a follow-up, but 1 should be fixed.

[eroman, 2014-08-27 18:00:57]

https://codereview.chromium.org/504413004/diff/1/content/child/webcrypto/jwk.cc
File content/child/webcrypto/jwk.cc (right):

https://codereview.chromium.org/504413004/diff/1/content/child/webcrypto/jwk....
content/child/webcrypto/jwk.cc:708: std::string base64EncodedText(input);
On 2014/08/27 17:22:15, Ryan Sleevi wrote:
> 1) variable naming / style

Good catch, Done.

> 2) This still seems to allow invalid Base64URL codings

I have added a TODO which links to https://codereview.chromium.org/504413004

> 
> I'm happy to leave 2 for a follow-up, but 1 should be fixed.

[eroman, 2014-08-27 22:22:24]

The CQ bit was checked by eroman@chromium.org

[commit-bot: I haz the power, 2014-08-27 22:24:05]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/eroman@chromium.org/504413004/40001

[commit-bot: I haz the power, 2014-08-27 23:16:20]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_arm64_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  android_clang_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-27 23:23:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-27 23:23:12]

Try jobs failed on following builders:
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[eroman, 2014-08-28 14:41:43]

The CQ bit was checked by eroman@chromium.org

[commit-bot: I haz the power, 2014-08-28 14:42:23]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/eroman@chromium.org/504413004/60001

[commit-bot: I haz the power, 2014-08-28 15:31:32]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_arm64_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-28 15:37:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-28 15:37:18]

Try jobs failed on following builders:
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)

[eroman, 2014-08-28 19:53:34]

The CQ bit was checked by eroman@chromium.org

[commit-bot: I haz the power, 2014-08-28 19:55:24]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/eroman@chromium.org/504413004/80001

[commit-bot: I haz the power, 2014-08-28 20:51:01]

Committed patchset #5 (id:80001) as e8e4314abcbc2e922d594c5bf0a4f4d9a3426bbe

[commit-bot: I haz the power, 2014-09-10 03:02:02]

Patchset 5 (id:??) landed as
https://crrev.com/7ddf94b2bd03be89f9c199f486a843a2c8d4862d
Cr-Commit-Position: refs/heads/master@{#292456}