Issue 50413011: Allow specifying the max texture count on the bots

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 50413011: Allow specifying the max texture count on the bots (Closed)

Created:
7 years, 1 month ago by robertphillips

Modified:
7 years, 1 month ago

Reviewers:
borenet, bsalomon

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Currently, the no-scratch-texture-reuse patch is dying on the N10 on the modecolorfilters test. This test creates ~1200 tiny layers yielding ~1200 textures which occupy only 2.5MB. In this situation the process gets killed on Android. Presumably the Mali driver either has a minimum page size or a bug. Limiting the max number of textures to 512 forces the InOrderDrawBuffer to be purged and frees up the textures for reuse.

Patch Set 1 #

Patch Set 2 : cleaned up #

Patch Set 3 : renamed GR_TEXTURE_CACHE to #

Patch Set 4 : Don't turn on for N10 just yet #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -18 lines)			Patch
M	gyp/common_variables.gypi	View	1 2	2 chunks	+4 lines, -2 lines	0 comments	Download
M	gyp/gpu.gyp	View	1 2	1 chunk	+7 lines, -2 lines	0 comments	Download
M	include/gpu/GrConfig.h	View	1 2	2 chunks	+13 lines, -4 lines	0 comments	Download
M	include/gpu/GrUserConfig.h	View	1 2	1 chunk	+7 lines, -1 line	0 comments	Download
M	platform_tools/android/bin/android_setup.sh	View	1 2 3	3 chunks	+5 lines, -5 lines	0 comments	Download
M	src/gpu/GrContext.cpp	View	1 2	2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

bsalomon

lgtm, but now might not be a bad time to change GR_*TEXTURE_CACHE* to GR_*RESOURCE_CACHE*

7 years, 1 month ago (2013-10-30 15:14:37 UTC) #2

robertphillips

7 years, 1 month ago (2013-10-30 17:05:28 UTC) #4

Message was sent while issue was closed.

committed as r12020.

For now this isn't being used for the N10. We will try a different approach to
resolving the N10 crash on the modecolorfilters GM.