Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ui/gfx/geometry/size.h

Issue 503953002: Do not use extern template declarations for RectBase etc for NaCl builds (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« ui/gfx/geometry/rect.h ('K') | « ui/gfx/geometry/rect_f.h ('k') | ui/gfx/geometry/size_f.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gfx/geometry/size.h
diff --git a/ui/gfx/geometry/size.h b/ui/gfx/geometry/size.h
index 5040a013503783132653e7c12df0e06448a5165b..7c95169c2c975c5f5d4eeb9edf0eb753a03fa2db 100644
--- a/ui/gfx/geometry/size.h
+++ b/ui/gfx/geometry/size.h
@@ -60,7 +60,7 @@ inline bool operator!=(const Size& lhs, const Size& rhs) {
}
#if !defined(COMPILER_MSVC)
-extern template class SizeBase<Size, int>;
+//extern template class SizeBase<Size, int>;
bbudge 2014/08/26 00:13:03 Did you mean for this to be #ifdef'd out?
Derek Schuff 2014/08/26 00:32:31 yes, fixed.
#endif
// This is declared here for use in gtest-based unit tests but is defined in
« ui/gfx/geometry/rect.h ('K') | « ui/gfx/geometry/rect_f.h ('k') | ui/gfx/geometry/size_f.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698