ui/gfx/geometry/rect.h - Issue 503953002: Do not use extern template declarations for RectBase etc for NaCl builds

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/gfx/geometry/rect.h

Issue 503953002: Do not use extern template declarations for RectBase etc for NaCl builds (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/gfx/geometry/rect.h

diff --git a/ui/gfx/geometry/rect.h b/ui/gfx/geometry/rect.h

index 83258fd7e143252c17bffe779f5119af911c74ea..abded4b0f3a35fdddc8fc6c3cecb7c0df39e8405 100644

--- a/ui/gfx/geometry/rect.h

+++ b/ui/gfx/geometry/rect.h

@@ -33,7 +33,6 @@ typedef struct tagRECT RECT;

namespace gfx {

class Insets;

bbudge 2014/08/26 00:13:03 Why remove this line?

Derek Schuff 2014/08/26 00:32:31 leftover from experimental edits,fixed.

class GFX_EXPORT Rect

: public RectBase<Rect, Point, Size, Insets, Vector2d, int> {

public:

@@ -131,7 +130,7 @@ inline Rect ScaleToEnclosedRect(const Rect& rect, float scale) {

return ScaleToEnclosedRect(rect, scale, scale);

}

-#if !defined(COMPILER_MSVC)

+#if !defined(COMPILER_MSVC) && !defined(__native_client__)

extern template class RectBase<Rect, Point, Size, Insets, Vector2d, int>;

#endif

« no previous file with comments | « ui/gfx/geometry/point_f.h ('k') | ui/gfx/geometry/rect_f.h » ('j') | ui/gfx/geometry/size.h » ('J')