Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 503873004: linux: Always use (64bit) gold for linking, even on 32bit. (Closed)

Created:
6 years, 3 months ago by Nico
Modified:
6 years, 3 months ago
Reviewers:
Lei Zhang, brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

linux: Always use (64bit) gold for linking, even on 32bit. All 32bit bots now have 64bit kernels and can run 64bit gold. So always use that. We already require running 64bit binaries for clang, and the official bots already used to do this for gold. This makes linking on 32bit bots faster, and simplifies our configurations. BUG=396333 TBR=brettw Committed: https://crrev.com/7cd5e7a3a82ebad8bf53e1236229d1094f8dafc6 Cr-Commit-Position: refs/heads/master@{#291904}

Patch Set 1 #

Patch Set 2 : gn #

Total comments: 2

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -37 lines) Patch
M build/common.gypi View 1 2 6 chunks +7 lines, -34 lines 0 comments Download
M build/config/compiler/BUILD.gn View 1 2 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
Nico
thakis@chromium.org changed reviewers: + thestig@chromium.org
6 years, 3 months ago (2014-08-25 23:40:25 UTC) #1
Nico
6 years, 3 months ago (2014-08-25 23:40:25 UTC) #2
Lei Zhang
lgtm https://codereview.chromium.org/503873004/diff/20001/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/503873004/diff/20001/build/common.gypi#newcode813 build/common.gypi:813: # 32bit hosts have to be 32-bit userland ...
6 years, 3 months ago (2014-08-26 01:01:49 UTC) #3
Nico
https://codereview.chromium.org/503873004/diff/20001/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/503873004/diff/20001/build/common.gypi#newcode813 build/common.gypi:813: # 32bit hosts have to be 32-bit userland with ...
6 years, 3 months ago (2014-08-26 03:20:33 UTC) #4
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 3 months ago (2014-08-26 03:20:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/503873004/40001
6 years, 3 months ago (2014-08-26 03:21:51 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium.linux ...
6 years, 3 months ago (2014-08-26 05:01:57 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-26 05:06:31 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/6597)
6 years, 3 months ago (2014-08-26 05:06:32 UTC) #9
Nico
thakis@chromium.org changed reviewers: + brettw@chromium.org
6 years, 3 months ago (2014-08-26 14:39:28 UTC) #10
Nico
tbr brettw for build/config/OWNERship
6 years, 3 months ago (2014-08-26 14:39:28 UTC) #11
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 3 months ago (2014-08-26 14:39:58 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/503873004/40001
6 years, 3 months ago (2014-08-26 14:40:35 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (40001) as c7864673b16236a2ec3cd435bb11608cbb76c1b4
6 years, 3 months ago (2014-08-26 14:55:03 UTC) #14
noms (inactive)
A revert of this CL (patchset #3) has been created in https://codereview.chromium.org/482173003/ by noms@chromium.org. The ...
6 years, 3 months ago (2014-08-26 15:20:18 UTC) #15
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:42:51 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/7cd5e7a3a82ebad8bf53e1236229d1094f8dafc6
Cr-Commit-Position: refs/heads/master@{#291904}

Powered by Google App Engine
This is Rietveld 408576698